New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use interface instead of implementation in Endpoint properties #104

Merged

OkGoDoIt merged 2 commits into OkGoDoIt:master from babrekel:interfaces

Apr 2, 2023

Contributor

babrekel commented Mar 31, 2023 •

edited

Loading

The problem is described in #68.

The endpoint properties should be defined as interfaces instead of classes so that they are also suitable for Moq tests. Additionally, the IChatEndpoint interface should be added as a property.

This PR replaces #69 as it would otherwise create a conflict between the changes.

Note that this is a breaking change.

babrekel and others added 2 commits

March 31, 2023 00:09


          Propagate interfaces to Endpoints to support mocking

a41ccf0


          Merge branch 'master' into interfaces

Owner

OkGoDoIt commented Apr 2, 2023

Thanks @babrekel!

OkGoDoIt merged commit d30ead8 into OkGoDoIt:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet