Change dependency num to num_traits to shrink dependency tree
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This crate only uses traits from the `num` crate. These traits live in their own crate called `num_traits` which has way fewer dependencies. By default, `num` pulls all its children crates such as `num-bigint` in. This in turn brings some heavy crates such as `rand` into the dependency tree.
|
Wow, thanks! Optimizations are always nice! It may not be a breaking change, but it's going to be bundled with other breaking changes, so it doesn't matter. By the way, I have been super lousy when it comes to getting this crate off the ground again, so I haven't decided if I'm just going to make an intermediate release now or put the RGB changes in there first. Either way, I don't know when I will release it. Not today, at least. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 28, 2018
76: Change dependency `num` to `num_traits` to shrink dependency tree r=Ogeon a=LukasKalbertodt This crate only uses traits from the `num` crate. These traits live in their own crate called `num_traits` which has way fewer dependencies. By default, `num` pulls all its children crates such as `num-bigint` in. This in turn brings some heavy crates such as `rand` into the dependency tree. I tried to use this crate in a wasm project and `rand` currently doesn't compile for the new wasm target. That's the way I found out. Changing dependencies like that is probably a breaking change? Or is it? Since `num` in turn had `num_traits` as a dependency? Maybe it's fine... Btw: awesome crate :)
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crate only uses traits from the
numcrate. These traits live intheir own crate called
num_traitswhich has way fewer dependencies. Bydefault,
numpulls all its children crates such asnum-bigintin. Thisin turn brings some heavy crates such as
randinto the dependency tree.I tried to use this crate in a wasm project and
randcurrently doesn't compile for the new wasm target. That's the way I found out.Changing dependencies like that is probably a breaking change? Or is it? Since
numin turn hadnum_traitsas a dependency? Maybe it's fine...Btw: awesome crate :)