Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add create RgbHue from degrees? #75

Closed
tiby312 opened this issue Dec 17, 2017 · 1 comment
Closed

add create RgbHue from degrees? #75

tiby312 opened this issue Dec 17, 2017 · 1 comment
Labels
easy / new contributor Does not require much Rust knowledge or domain knowledge
Milestone
0.4.0

Comments

@tiby312
Copy link

tiby312 commented Dec 17, 2017

seems like can only make from radians
@Ogeon
Copy link
Owner

Ogeon commented Dec 18, 2017

You can actually do that already, using just from, as in RgbHue::from(my_hue) or my_hue.into(), but I agree that it's not super obvious. Thanks for reporting it!

@Ogeon Ogeon added the easy / new contributor Does not require much Rust knowledge or domain knowledge label Apr 3, 2018
@Ogeon Ogeon added this to the 0.4.0 milestone Apr 3, 2018
@Ogeon Ogeon mentioned this issue Apr 20, 2018
Merged
bors bot added a commit that referenced this issue Apr 20, 2018
@bors @Ogeon
Merge #89
af48007 
89: Improve the hue types a bit r=Ogeon a=Ogeon

Closes #75, #79

Co-authored-by: Erik Hedvall <[email protected]>
@bors bors bot closed this as completed in #89 Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy / new contributor Does not require much Rust knowledge or domain knowledge
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
2 participants
@Ogeon @tiby312