Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the Color type #72

Closed
Ogeon opened this issue Aug 8, 2017 · 1 comment
Closed

Remove the Color type #72

Ogeon opened this issue Aug 8, 2017 · 1 comment

Comments

@Ogeon
Copy link
Owner

Ogeon commented Aug 8, 2017

It's unwieldy to implement, hides things unnecessarily, and I suspect that it's not as useful as I initially thought it would be. It feels like it does more harm than good.
@Ogeon Ogeon changed the title Consider removing the Color type Remove the Color type May 26, 2018
@Ogeon
Copy link
Owner Author

Ogeon commented May 26, 2018

I would rather make it easier to create custom dynamic Color types.

@Ogeon Ogeon added this to the 0.5.0 milestone Jul 10, 2018
@Veykril Veykril mentioned this issue Oct 2, 2018
Merged
bors bot added a commit that referenced this issue Oct 2, 2018
@bors @Veykril
Merge #119
ec0e482 
119: Remove the color enum r=Ogeon a=Veykril

This PR removes the color type enum as described in #72. I do not know if this has any side effects tough, everything compiles fine on my end, tests and examples compile and run as well. The only difference i noticed is in the `readme_examples/readme_manipulation` example part. The latter two colors arent the same but im not sure why.

Closes #72.

Co-authored-by: Lukas Wirth <[email protected]>
@bors bors bot closed this as completed in #119 Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ogeon