TSC Migration

Not sure how to default export from JSDoc-powered JS, when in CommonJS. Once I move to ESM and or TS it's not an issue, but I was kind of surprised that this didn't work already, since it's an existing practice for Node packages that have been around for a while. I'm probably just doing it wrong, but I'm not totally sure. I thought it might've been the part where it was assigning both the variable and the `module.exports` in the same line, but that didn't fix the errors either.

microsoft/TypeScript#37832
https://stackoverflow.com/questions/60009092/declaration-will-not-emit-due-to-private-name-usage
microsoft/TypeScript#2719

Super bowl!!!!! aaaeaaeggh, 380 green hut, AA

.gitignore

@@ -1 +1,2 @@
 node_modules/
+dist/

package.json

@@ -3,7 +3,9 @@
   "version": "2.0.4",
   "description": "A cdb implementation for node.js",
   "author": "Eric Norris",
-  "main": "./src/index.js",
+  "type": "commonjs",
+  "main": "./dist/index.js",
+  "types": "./dist/index.d.ts",
   "repository": {
     "type": "git",
     "url": "https://github.com/ericnorris/node-cdb.git"
@@ -14,6 +16,8 @@
     "vows": "^0.8.0"
   },
   "scripts": {
+    "build": "tsc --project ./tsconfig.build.json",
+    "dev": "tsc --watch",
     "test": "vows --spec"
   },
   "keywords": [

src/readable-cdb.js

@@ -5,14 +5,16 @@ var fs = require('fs'),
     HEADER_SIZE = 2048,
     TABLE_SIZE  = 256;
 
-var readable = module.exports = function(/** @type {string} */ file) {
+var readable = function(/** @type {string} */ file) {
     this.file = file;
     this.header = new Array(TABLE_SIZE);
 
     this.fd = null;
     this.bookmark = /** @type {((callback: (error: Error | null, buffer?: Buffer | null) => void) => void) | null} */ (null);
 };
 
+module.exports = readable;
+
 readable.prototype.open = function(/** @type {(error: NodeJS.ErrnoException, readable?: typeof this) => void} */ callback) {
     var self = this;
 

src/writable-cdb.js

@@ -8,7 +8,7 @@ var events = require('events'),
     TABLE_SIZE = 256;
 
 // Writable CDB definition
-var writable = module.exports = function(/** @type {string} */ file) {
+var writable = function(/** @type {string} */ file) {
     this.file = file;
     this.filePosition = 0;
 
@@ -19,6 +19,8 @@ var writable = module.exports = function(/** @type {string} */ file) {
     this.hashtableStream = /** @type {fs.WriteStream | null} */ (null);
 };
 
+module.exports = writable;
+
 // extend EventEmitter for emit()
 util.inherits(writable, events.EventEmitter);
 

tsconfig.build.json

@@ -0,0 +1,17 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "rootDir": "./src",
+    "outDir": "./dist",
+    "noEmit": false,
+    "declaration": true,
+    "sourceMap": true
+  },
+  "include": [
+    "./src/**/*"
+  ],
+  "exclude": [
+    "./test",
+    "./benchmark"
+  ]
+}

tsconfig.json

@@ -2,7 +2,7 @@
   "compilerOptions": {
     "allowJs": true,
     "checkJs": true,
-    "module": "NodeNext",
+    "module": "CommonJS",
     "target": "ESNext",
     "isolatedModules": true,
     "noEmit": true,