LocalStatusSQLite.py: version aware threadsafety check (fixes #136)

[theesm]

This PR

fixes #136 in a version-aware way. We specifically want to check wether sqlite.threadsafety returns the integer constant for SERIALIZED mode; so the value returned has to be 3 for Python >= 3.11 and 1 for Python <=3.10 to not break backwards compatibility.

• I've read the DCO.
• I've read the Coding Guidelines
• The relevant informations about the changes stands in the commit message, not here in the message of the pull request.
• Code changes follow the style of the files they change.
• Code is tested (provide details).

References

• Python 3.11 breaks sqlite multi-threading check #136 talks about this issue
• Update sqlite3 multi-threading check for Py3.11 #137 points into the right direction, even though it ignores the code comment that the check must check for serialize mode; as every mode except single threaded is allowed here.

Additional information

This is an slightly improved version of the local hotfix I have commented as a diff in #137.

[ag91]

any chance this could be merged? I needed to modify code manually to gather my emails :P

[noorul]

When will be the next release with this fix? Every time I have to manually apply this patch on MacOS.

[thekix]

Hi @noorul ,

I think the problem was solved with the patch attached. Do you need a new release of OfflineIMAP to include these changes?

Best regards,
kix

[josefig]

Hello, is this fixed? I currently have installed the offlineimap 8.0.0 using brew updated in Mac Sonoma 14.1.1, but i get the same error:

  assert sqlite.threadsafety == 1, 'Your sqlite is not multithreading safe.'
AssertionError: Your sqlite is not multithreading safe.

and the file is:
/usr/local/Cellar/offlineimap/8.0.0_1/libexec/lib/python3.12/site-packages/offlineimap/folder/LocalStatusSQLite.py

should I apply the patch manually?
Thanks in advance

[olopost]

Hello, is this fixed? I currently have installed the offlineimap 8.0.0 using brew updated in Mac Sonoma 14.1.1, but i get the same error:

  assert sqlite.threadsafety == 1, 'Your sqlite is not multithreading safe.'
AssertionError: Your sqlite is not multithreading safe.

and the file is: /usr/local/Cellar/offlineimap/8.0.0_1/libexec/lib/python3.12/site-packages/offlineimap/folder/LocalStatusSQLite.py

should I apply the patch manually? Thanks in advance

Thanks for the post, same issue with brew on Mac Sonoma. I update manually and all works

[noorul]

Not sure why are we not making a release