Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle [ALREADYEXISTS] and Mailbox already exists! #646

Closed
wants to merge 1 commit into from

Conversation

chris001
Copy link
Member

@chris001 chris001 commented Feb 6, 2020

Make compatible with IMAP servers that give the reason code "[ALREADYEXISTS]" and IMAP servers that give natural language reason "Mailbox already exists!" by searching for the two words "already" and "exists" in the exception reason string.

This v1.1 template stands in .github/.

This PR

Add character x [x].

  • I've read the DCO.
  • I've read the Coding Guidelines
  • The relevant informations about the changes stands in the commit message, not here in the message of the pull request.
  • Code changes follow the style of the files they change.
  • Code is tested (provide details).

References

Additional information

Tested for syntax by writing a few lines python program with this code and it ran fine.

Make compatible with IMAP servers that give the reason code "[ALREADYEXISTS]" and IMAP servers that give natural language reason "Mailbox already exists!" by searching for the two words "already" and "exists" in the exception reason string.
@nicolas33
Copy link
Member

nicolas33 commented Feb 6, 2020

Applied, thank you.

@nicolas33 nicolas33 closed this Feb 6, 2020
@nicolas33
Copy link
Member

Fixed a trailing whitespace and the commit message lines length.

@chris001 chris001 deleted the chris001-issue-645-detect-exception-reason branch February 6, 2020 18:52
@Segment0895
Copy link

@nicolas33 this patch appears to not have been applied to release offlineimap v8.0.0, imaplib2 v3.06, Python v3.11.4, OpenSSL 3.0.9 30 May 2023 (git pull of master on a Fedora 38).

Monkey-patching it solved one of my Office 365 migration problems.

Do you want me to open a proper pull request based on @chris001 code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants