Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): use graph apis to handle aad apps #9900

Merged
merged 6 commits into from
Sep 14, 2023
Merged

test(e2e): use graph apis to handle aad apps #9900

merged 6 commits into from
Sep 14, 2023

Conversation

KennethBWSong
Copy link
Contributor

@KennethBWSong KennethBWSong commented Sep 11, 2023 •
edited by kuojianlu
Loading

Resolve #9883.

@codecov
Copy link

codecov bot commented Sep 11, 2023 •
edited
Loading

Codecov Report

Merging #9900 (c01eca5) into dev (6071425) will increase coverage by 0.00%.
Report is 2 commits behind head on dev.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #9900   +/-   ##
=======================================
  Coverage   85.71%   85.72%           
=======================================
  Files         445      445           
  Lines       25426    25426           
  Branches     4855     4855           
=======================================
+ Hits        21795    21796    +1     
  Misses       1911     1911           
+ Partials     1720     1719    -1

see 1 file with indirect coverage changes

@kuojianlu kuojianlu changed the title tests: use graph apis to handle aad apps test(e2e): use graph apis to handle aad apps Sep 14, 2023
@kuojianlu kuojianlu marked this pull request as ready for review September 14, 2023 08:51
swatDong
swatDong previously approved these changes Sep 14, 2023
View reviewed changes
@kuojianlu kuojianlu merged commit e58796e into dev Sep 14, 2023
@wenytang-ms wenytang-ms deleted the bowsong/use_graph branch September 19, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuojianlu kuojianlu kuojianlu approved these changes

@swatDong swatDong swatDong left review comments

@kimizhu kimizhu Awaiting requested review from kimizhu kimizhu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove usage of /api/aadapp/{id} endpoint in TDP
3 participants
@KennethBWSong @swatDong @kuojianlu