Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spfx questions #9788

Merged
merged 2 commits into from
Aug 31, 2023
Merged

fix: spfx questions #9788

merged 2 commits into from
Aug 31, 2023

Conversation

jayzhang
Copy link
Member

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #9788 (b2cedcf) into dev (8d68ea3) will increase coverage by 0.00%.
Report is 6 commits behind head on dev.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #9788   +/-   ##
=======================================
  Coverage   85.42%   85.42%           
=======================================
  Files         440      440           
  Lines       25118    25120    +2     
  Branches     4788     4789    +1     
=======================================
+ Hits        21456    21458    +2     
  Misses       1937     1937           
  Partials     1725     1725           
Files Changed Coverage Δ
packages/fx-core/src/question/create.ts 91.85% <ø> (ø)
...e/src/question/options/DeployAadManifestOptions.ts 100.00% <ø> (ø)
...ore/src/question/options/PermissionGrantOptions.ts 100.00% <ø> (ø)
...core/src/question/options/PermissionListOptions.ts 100.00% <ø> (ø)
...ore/src/question/options/PreviewTeamsAppOptions.ts 100.00% <ø> (ø)
...core/src/question/options/SPFxAddWebpartOptions.ts 100.00% <ø> (ø)
...src/question/options/SelectTeamsManifestOptions.ts 100.00% <ø> (ø)
...re/src/question/options/ValidateTeamsAppOptions.ts 100.00% <ø> (ø)
packages/fx-core/src/question/other.ts 81.78% <ø> (ø)

... and 2 files with indirect coverage changes

yuqizhou77
yuqizhou77 previously approved these changes Aug 30, 2023
@jayzhang jayzhang merged commit efe5773 into dev Aug 31, 2023
27 checks passed
@jayzhang jayzhang deleted the huajie/cli-spfx branch August 31, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants