Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: show three buttons at most #12900

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

yuqizhou77
Copy link
Contributor

@yuqizhou77 yuqizhou77 commented Dec 11, 2024

  • move similar issue button to message if there are going to be four buttons. And then we can keep the buttons less than four.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.10%. Comparing base (9b785f1) to head (f6e2e84).
Report is 9 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##              dev   #12900    +/-   ##
========================================
  Coverage   90.10%   90.10%            
========================================
  Files         578      578            
  Lines       34527    34555    +28     
  Branches     6761     6927   +166     
========================================
+ Hits        31110    31137    +27     
  Misses       1505     1505            
- Partials     1912     1913     +1     
Files with missing lines Coverage Δ
packages/vscode-extension/src/error/common.ts 95.04% <100.00%> (+0.25%) ⬆️
.../vscode-extension/src/handlers/openLinkHandlers.ts 96.85% <100.00%> (+0.24%) ⬆️

... and 4 files with indirect coverage changes

@yuqizhou77 yuqizhou77 merged commit c548821 into dev Dec 12, 2024
18 checks passed
@yuqizhou77 yuqizhou77 deleted the yuqzho/error-notification-four-button branch December 12, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants