Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support env variables in localization.json #12889

Merged

Conversation

HuihuiWu-Microsoft
Copy link
Contributor

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.10%. Comparing base (ae4f2b9) to head (ff5cd9b).
Report is 6 commits behind head on dev.

Files with missing lines Patch % Lines
.../src/component/driver/teamsApp/createAppPackage.ts 80.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##              dev   #12889    +/-   ##
========================================
  Coverage   90.10%   90.10%            
========================================
  Files         578      578            
  Lines       34527    34541    +14     
  Branches     6717     6904   +187     
========================================
+ Hits        31110    31123    +13     
  Misses       1505     1505            
- Partials     1912     1913     +1     
Files with missing lines Coverage Δ
...c/component/driver/teamsApp/utils/ManifestUtils.ts 82.80% <100.00%> (+0.72%) ⬆️
.../fx-core/src/component/driver/teamsApp/validate.ts 91.16% <100.00%> (ø)
.../src/component/driver/teamsApp/createAppPackage.ts 94.71% <80.00%> (-0.77%) ⬇️

... and 2 files with indirect coverage changes

@HuihuiWu-Microsoft HuihuiWu-Microsoft merged commit 82fefd9 into OfficeDev:dev Dec 11, 2024
18 checks passed
@HuihuiWu-Microsoft HuihuiWu-Microsoft deleted the env-support-localization branch December 11, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants