Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: troubleshoot UI #12851
feat: troubleshoot UI #12851
Changes from 6 commits
13feaf5
2cb5564
5af0702
9873701
fa50402
f19021f
a27361a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 52 in packages/vscode-extension/src/error/common.ts
Codecov / codecov/patch
packages/vscode-extension/src/error/common.ts#L51-L52
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the UI effect of showing 3/4 buttons?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If at most four buttons. user can hover on the button to view full text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK thanks! Also, I'd suggest discussing with PM/UX to decide the button number and the primary button to achieve better effect because the main purpose is to increase entry point to troubleshooting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just left a comment to UX about button number :) Thanks for your suggestion.
The troubleshoot button has been discussed that should not be the primary one.