Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: merge back to dev after vs17.13P2 release #12788

Merged
merged 9 commits into from
Nov 26, 2024
Merged

Conversation

Siglud
Copy link
Member

@Siglud Siglud commented Nov 26, 2024

No description provided.

@Siglud Siglud changed the title build: merge back to main after vs17.13P2 release build: merge back to dev after vs17.13P2 release Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 96.23656% with 14 lines in your changes missing coverage. Please review.

Project coverage is 90.28%. Comparing base (4991a9a) to head (273a414).
Report is 47 commits behind head on dev.

Files with missing lines Patch % Lines
...ackages/spec-parser/src/validators/smeValidator.ts 91.66% 1 Missing and 4 partials ⚠️
packages/fx-core/src/core/FxCore.ts 95.95% 1 Missing and 3 partials ⚠️
...ackages/fx-core/src/component/coordinator/index.ts 40.00% 0 Missing and 3 partials ⚠️
...x-core/src/component/driver/script/scriptDriver.ts 92.30% 0 Missing and 1 partial ⚠️
packages/fx-core/src/core/collaborator.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #12788      +/-   ##
==========================================
+ Coverage   90.01%   90.28%   +0.26%     
==========================================
  Files         576      577       +1     
  Lines       34158    35415    +1257     
  Branches     6680     7170     +490     
==========================================
+ Hits        30748    31973    +1225     
- Misses       1508     1515       +7     
- Partials     1902     1927      +25     
Files with missing lines Coverage Δ
packages/cli/src/cmds/preview/constants.ts 100.00% <100.00%> (ø)
packages/cli/src/commands/engine.ts 89.86% <ø> (ø)
...ackages/cli/src/commands/models/m365Sideloading.ts 95.23% <ø> (ø)
packages/cli/src/commands/models/m365Unacquire.ts 100.00% <ø> (ø)
packages/cli/src/telemetry/cliTelemetryEvents.ts 100.00% <100.00%> (ø)
packages/cli/src/userInteraction.ts 86.95% <100.00%> (+4.39%) ⬆️
packages/fx-core/src/common/secretmasker/masker.ts 100.00% <100.00%> (+4.76%) ⬆️
packages/fx-core/src/common/stringUtils.ts 100.00% <100.00%> (ø)
...core/src/component/configManager/actionInjector.ts 98.95% <100.00%> (+2.18%) ⬆️
...onent/driver/file/createOrUpdateEnvironmentFile.ts 100.00% <100.00%> (+1.69%) ⬆️
... and 27 more

... and 15 files with indirect coverage changes

@eriolchan eriolchan merged commit a2c09e8 into dev Nov 26, 2024
41 checks passed
@eriolchan eriolchan deleted the release/VS17.13P2 branch November 26, 2024 08:37
@Siglud Siglud restored the release/VS17.13P2 branch November 28, 2024 08:22
@adashen adashen deleted the release/VS17.13P2 branch January 2, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants