feat: dc with api plugin generator & template update #12104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yuqizhou77
commented
Jul 30, 2024
•
yuqizhou77
commented
- A new generator for apps with API plugin built with Azure Function.
- Updated API plugin from scratch with none auth template by combining contents from the original api-plugin-from-scratch and "copilot-gpt-from-scratch-plugin". Will update templates with api key and oauth later. (TODO: will ask PM to review all readmes later.)
- Updated icons in some templates including templates of copilot extension without source code, bot plugins and api plugin from scratch with none auth.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packages/fx-core/src/component/generator/declarativeCopilotAction/generator.ts
Fixed
Show fixed
Hide fixed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #12104 +/- ##
========================================
Coverage 89.44% 89.45%
========================================
Files 570 571 +1
Lines 33554 33583 +29
Branches 6626 6464 -162
========================================
+ Hits 30014 30043 +29
Misses 1583 1583
Partials 1957 1957
|
yuqizhou77
changed the title
yuqizhou77
changed the title
yuqizhou77
requested review from
hund030,
eriolchan,
huimiu,
Alive-Fish,
jayzhang,
yukun-dong and
JerryYangKai
as code owners
huimiu
previously approved these changes
Jul 30, 2024
hund030
previously approved these changes
Jul 30, 2024
| isDeclarativeCopilot = "is-declarative-copilot", | ||
| } | ||
|
|
||
| export class ApiPluginFromScratchGenerator extends DefaultTemplateGenerator { |
There was a problem hiding this comment.
You may want to add a property named componentName. So that we can distinguish the telemetry events that are from this generator.
huimiu
reviewed
Jul 30, 2024
| isDeclarativeCopilot = "is-declarative-copilot", | ||
| } | ||
|
|
||
| export class ApiPluginFromScratchGenerator extends DefaultTemplateGenerator { |
There was a problem hiding this comment.
A small suggestion: can we call it CopilotExtensionGenerator?
There was a problem hiding this comment.
I want to differentiate it from the SpecGenerator in apispec folder. so maybe copilotExtensionFromScrathGenerator?
There was a problem hiding this comment.
Sure, my concern is this generator is not only for the API Plugin
Alive-Fish
previously approved these changes
Jul 30, 2024
huimiu
approved these changes
Jul 30, 2024
Alive-Fish
approved these changes
Jul 30, 2024
hund030
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.