refactor: split activate() from handlers #11858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #11858 +/- ##
==========================================
+ Coverage 88.87% 88.95% +0.07%
==========================================
Files 550 551 +1
Lines 33012 33030 +18
Branches 6419 6536 +117
==========================================
+ Hits 29341 29382 +41
+ Misses 1728 1709 -19
+ Partials 1943 1939 -4
|
yiqing-zhao
requested review from
1openwindow,
HuihuiWu-Microsoft,
nliu-ms and
tecton
as code owners
tecton
approved these changes
Jun 20, 2024
MSFT-yiz
pushed a commit
that referenced
this pull request
Jul 10, 2024
* docs: Update package.nls.json * Update aadAppClient.test.ts * Update aadManifestHelper.test.ts * Update aadManifestHelper.test.ts * Update aadManifestHelper.test.ts * Update aadManifestHelper.test.ts * Update aadManifestHelper.test.ts * fix: update expected error message * docs: Update package.nls.json * docs: Update package.nls.json * docs: Update package.nls.json * Update deployError.test.ts * docs: Update package.nls.json * fix: remove proposed api (ChatRequest.location) and refine the api folder * fix: remove proposed api ChatUserActionEvent * refactor: migrate office xml addin generator * fix: resolve comments * fix: rollback undesired changes * refactor: cleanup xml generator in fxcore * fix: remove unused strings * refactor: add telemetry for office agent * fix: add telemetry for office agent * fix: add telemetry for office agent for unit test * fix: add telemetry for office agent for unit test 2 * refactor: add streaming output to office agent * refactor: split activate() from handlers (#11858) * refactor: split activate() from handlers * test: fix ut * test: add ut * fix: fix ut * test: fix can\'t find sample page element (#11866) * test: fix can\'t find sample page element --------- Co-authored-by: Ivan_Chen <[email protected]> * fix: add telemetry for office agent for unit test - bug fix * refactor: move create new project handler to seperate file (#11862) * refactor: move create project handler * refactor: move create project handler * refactor: ut * refactor: ut * refactor: ut * ci: script * refactor: move utils and filesystem watcher (#11865) * refactor: move utils and filesystem watcher * test: add ut * refactor: update extension test folder structure to keep consistent with code structure * test: update SPFx validation (#11867) * test: update SPFx validation * test: add author back * test: add ut * fix: fix ut timeout * fix: add telemetry for office agent for unit test - bug fix 2 * fix: fix ut coverage * fix: fix streaming output behavior * test: remove node version check (#11871) * test: remove node version check * test: add author back * refactor: move account related functions to separate files (#11870) * refactor: move account related functions to separate files * test: fix ut * test: add ut * refactor: add help link to cli debug in desktop client (#11861) * perf(spec-parser): remove unused properties when filtering (#11872) * perf(spec-parser): remove unused properties when filtering * perf: update test cases to make codecov happy --------- Co-authored-by: rentu <[email protected]> * refactor: seperate manifest handlers (#11869) * refactor: manifest handlers * test: ut * test: ut * ci: enable git leaks to check sensitive (#11878) * ci: enable git leaks to check sensitive * ci: remove the detect logic * ci: update logic * refactor: switch to new manifest handlers (#11879) * refactor: refactor autoOpenProejct, readme and collaborator handlers (#11881) * refactor: refactor autoOpenProejct and readme handlers * fix: fix CodeQL alert * test: update ut * perf(spec-paser): update $when in AC card to enhance compatibility (#11880) Co-authored-by: rentu <[email protected]> * perf(spec-parser): change class name CopilotPluginGenerator -> OpenAPISpecGenerator (#11885) Co-authored-by: rentu <[email protected]> * refactor: tutorials handlers (#11886) * refactor: tutorials handlers * test: add ut * fix: add telemetry for office agent for unit test - bug fix 3 * fix: add telemetry for office agent for unit test - remove no use import * ci: use trufflehog (#11894) * ci: use trufflehog * ci: update * ci: update * test: update test case since template updated (#11874) * refactor: seperator env handlers (#11890) * refactor: seperator env handlers * test: ut * test: ut * test: ut * refactor: rename variable * test: fix can\'t find sample page element (#11889) * test: fix can\'t find sample page element --------- Co-authored-by: Ivan_Chen <[email protected]> * refactor: aadManifest, env, openLinkHandlers (#11897) * refactor: aadManifestHandlers * test: update ut * refactor: update envHandlers * refactor: openLink handlers * test: add ut * test: update white list for doc check (#11900) Co-authored-by: Ivan_Chen <[email protected]> * perf: fix type b copilot template typo (#11899) Co-authored-by: rentu <rentu> * refactor: clean up in product survey codes (#11888) * refactor: seperate scaffold from tdp (#11910) * refactor: seperate scaffold from tdp * test: ut * refactor: refactor handlers (#11902) * refactor: refctor handlers * test: add ut * refactor: account handlers * test: add ut * test: add ut * test: add ut * test: add ut * fix: add telemetry for office agent for unit test - resolve comments * test: fix ai assistant bot ui test (#11908) Co-authored-by: Ivan_Chen <[email protected]> * refactor: support cli cert sp login (#11891) * refactor: seperator migration handler (#11911) * refactor: seperator migration handler * test: ut * test: ut * test: ut * test: ut * test: ut * test: ut * refactor: lifecycle (#11914) * refactor: new generator feature alignment (#11915) * refactor: new generator feature aglinment * test: refine unit tests * fix: add telemetry for office agent for unit test - resolve comments * fix: add telemetry for office agent for unit test - bug fix 4 * ci: remove security issue on metrics sample (#11919) * refactor: handlers (#11921) * refactor: handlers * test: add ut * fix: add telemetry for office agent for unit test - bug fix 5 * fix: add telemetry for office agent for unit test - bug fix 6 * fix: environment variable error message * refactor: triggerV3Migration (#11927) * fix: add telemetry for office agent for unit test - bug fix 7 * test: update AKA white list (#11928) Co-authored-by: Ivan_Chen <[email protected]> * test: update api me validate (#11929) * test: update api me validate * test: update api me validate * fix: string update * fix: add telemetry for office agent for unit test - bug fix * fix: add telemetry for office agent for unit test - bug fix 9 * fix: unit test * test: update testcase id (#11931) * fix: add telemetry for office agent for unit test - bug fix 10 * fix: add telemetry for office agent for unit test - bug fix 11 * fix: add telemetry for office agent for unit test - bug fix 12 * fix: add telemetry for office agent for unit test - bug fix 13 * docs: update code owner (#11932) * fix: remove auto popup install dependency (#11905) * fix: remove auto popup install dependency * fix: modfiy UT for remove auto install dependency * fix: remove no needed import * fix: remove code no longer used * fix: remove auto install in officedev --------- Co-authored-by: Ruiqi Yang (from Dev Box) <[email protected]> * fix: resolve vulnerability (#11937) * refactor: the adaptive card issue in copilot plugin (#11551) * refactor: update app name variable in Copilot manifest files (#11509) * test: importing SPFx single web part (#11939) * test: update linkunfurling validate (#11940) * fix: ws package (#11938) * fix: mos api telemetry (#11936) * fix: mos api telemetry * fix: mos api telemetry * test: ut * test: ut * test: fix e2e test number link * refactor: update folder strucutre (#11930) * refactor: update folder structure for progressHandler and telemetry * refactor: update handlers folder strucuture * test: update ut * test: fix ut * fix: not show the changelog prompt on a fresh install * build: add code owners (#11948) * build: add code owners * build: update codeowners * fix: fix code owners * build: update import/no-cycle eslint rule (#11950) * fix: remove test tool debug option of all Python templates (#11951) * fix: remove test tool option in python tpls * fix: remove yml and envs * fix: delete extra slashs * fix: fix * feat: show diagnostics (#11954) * refactor: draft * refactor: minor * refactor: more * refactor: more refactor: more refactor: more refactor: more * refactor: more * test: ut * feat: update bot csharp templates to msi (batch 1) (#11807) * refactor: update * refactor: update * refactor: update * refactor: update * refactor: update * test: clean up VS testing resources (#11956) * perf(spec-parser): optimize "None Auth", special media type, AC card gen (#11946) * perf(spec-parser): optimize "None Auth", special media type, AC card gen * perf: fix codecov issue * perf: fix codecov issue * perf: update strings --------- Co-authored-by: rentu <rentu> * test: fix sdk e2e test (#11957) * test: automate notification tests (#11949) * fix: refine invalid project error message (#11945) * fix: refine invalid project error message * fix: refine invalid project error message * fix: refine invalid project error message * fix: refine invalid project error message * fix: error * test: ut * refactor: retire new generator feature flag (#11958) * feat: update bot csharp templates to msi (batch 2) (#11955) * feat: update to msi * refactor: update * refactor: update * refactor: update * refactor: update * ci: upgrade pnpm setup to v4 (#11962) * ci: upgrade pnpm setup to v4 * ci: update * Revert "ci: update" This reverts commit 049b707. * ci: update * test: update runs OS (#11960) Co-authored-by: Ivan_Chen <[email protected]> * chore: Adds CodeTour to the RAG JS and TS templates (#11953) * Adds CodeTour to the RAG JS template * Adds CodeTour for the TS sample Updates readme with a link to the Graph connector sample * Adds CodeTour as a recommended extension * refactor: support github devtunnel (#11964) * refactor: support github devtunnel * refactor: update test case * refactor: string update (#11965) * fix: outlook addin debug failure (#11963) * test: ut * test: ut * test: ut * test: import multiple SPFx web part (#11967) * test: import multiple spfx web part * test: add author back * test: fix format check issue * test: update creating copilot engine copilot (#11969) * test: change channel dashboard app url (#11970) Co-authored-by: Ivan_Chen <[email protected]> * refactor: unify feature flag definitions (#11968) * refactor: unify feature flag definitions * refactor: unify feature flag definitions * feat: update (#11973) * fix: import SPFx project fail due to case sensitive file system on ub… (#11972) * fix: import SPFx project fail due to case sensitive file system on ubuntu * test: fix ut fail * test: add ut to fix code coverage * refactor: update API Key label to include Bearer Token Auth (#11977) * perf: add spec-not-valid-details in validate-api-spec telemetry (#11974) Co-authored-by: rentu <rentu> * refactor: update to API plugin (#11975) * refactor: update to api plugin * refactor: more * fix: support m365 non-interactive login (#11978) * docs: Update package.nls.json (#11541) * docs: Update package.nls.json * Update create.test.ts * Update create.test.ts * Update update.test.ts * Update update.test.ts * Update create.test.ts * test: spfx add preview in e2e test (#11971) Co-authored-by: Ivan_Chen <[email protected]> * perf: improve MissingEnvironmentVariablesError message (#11981) * perf: improve MissingEnvironmentVariablesError message * fix: test case --------- Co-authored-by: rentu <rentu> * test: remove useless link from migration assets (#11983) * refactor: update CLI question/option id (#11982) * refactor: option id * test: ut * test: ut * test: ut * fix: add plugin * test: update migration case clean up (#11984) * test: update migration case clean up * test: update sample large scale case clean up --------- Co-authored-by: Ivan_Chen <[email protected]> * feat: cli uninstall (#11917) * feat: cli uninstall * test: add e2e test for dotnot workflow bot (#11987) --------- Co-authored-by: supkasar <[email protected]> Co-authored-by: Yiqing Zhao <[email protected]> Co-authored-by: Zhiyu You <[email protected]> Co-authored-by: Gavin Gu <[email protected]> Co-authored-by: haojiangliu <[email protected]> Co-authored-by: Siyuan Chen <[email protected]> Co-authored-by: Ivan_Chen <[email protected]> Co-authored-by: Huajie Zhang <[email protected]> Co-authored-by: Helly Zhang <[email protected]> Co-authored-by: Zihong <[email protected]> Co-authored-by: Tian Yuan <[email protected]> Co-authored-by: rentu <[email protected]> Co-authored-by: rentu <[email protected]> Co-authored-by: wenyt <[email protected]> Co-authored-by: Zhijie Huang <[email protected]> Co-authored-by: HuihuiWu-Microsoft <[email protected]> Co-authored-by: FanH <[email protected]> Co-authored-by: Ning Tang <[email protected]> Co-authored-by: Annefch <[email protected]> Co-authored-by: Yuqi Zhou <[email protected]> Co-authored-by: ruiqiyang-MSFT <[email protected]> Co-authored-by: Ruiqi Yang (from Dev Box) <[email protected]> Co-authored-by: Hui Miao <[email protected]> Co-authored-by: frankqianms <[email protected]> Co-authored-by: yukun-dong <[email protected]> Co-authored-by: Qianhao Dong <[email protected]> Co-authored-by: Waldek Mastykarz <[email protected]> Co-authored-by: anchenyi <[email protected]> Co-authored-by: Dooriya Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/28240424