Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consistant env name regex #11810

Merged
merged 1 commit into from
Jun 12, 2024
Merged

fix: consistant env name regex #11810

merged 1 commit into from
Jun 12, 2024

Conversation

jayzhang
Copy link
Member

@jayzhang jayzhang marked this pull request as ready for review June 12, 2024 07:41
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.51%. Comparing base (1742b3d) to head (4d89946).
Report is 3 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #11810      +/-   ##
==========================================
- Coverage   88.51%   88.51%   -0.01%     
==========================================
  Files         536      536              
  Lines       32894    32893       -1     
  Branches     6438     6486      +48     
==========================================
- Hits        29117    29116       -1     
  Misses       1809     1809              
  Partials     1968     1968              
Files Coverage Δ
packages/fx-core/src/component/utils/envUtil.ts 89.05% <100.00%> (ø)

... and 1 file with indirect coverage changes

@jayzhang jayzhang merged commit 69c7013 into dev Jun 12, 2024
19 checks passed
@jayzhang jayzhang deleted the huajie/env-name-regex branch June 12, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants