Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update global variables and resolve dependency cycle issues #11791

Merged
merged 6 commits into from
Jun 11, 2024

Conversation

yiqing-zhao
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 90.20979% with 14 lines in your changes missing coverage. Please review.

Project coverage is 88.49%. Comparing base (6e69e41) to head (523cc6f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #11791      +/-   ##
==========================================
+ Coverage   88.44%   88.49%   +0.05%     
==========================================
  Files         530      535       +5     
  Lines       32457    32470      +13     
  Branches     6382     6255     -127     
==========================================
+ Hits        28707    28735      +28     
+ Misses       1817     1803      -14     
+ Partials     1933     1932       -1     
Files Coverage Δ
packages/vscode-extension/src/codeLensProvider.ts 78.77% <100.00%> (ø)
packages/vscode-extension/src/featureFlags.ts 100.00% <100.00%> (ø)
packages/vscode-extension/src/globalVariables.ts 82.22% <100.00%> (+1.73%) ⬆️
...kages/vscode-extension/src/handlers/walkthrough.ts 92.85% <100.00%> (+0.54%) ⬆️
packages/vscode-extension/src/hoverProvider.ts 83.33% <100.00%> (-0.31%) ⬇️
packages/vscode-extension/src/officeDevHandlers.ts 93.70% <100.00%> (-0.05%) ⬇️
...ges/vscode-extension/src/telemetry/extTelemetry.ts 80.68% <100.00%> (-0.22%) ⬇️
packages/vscode-extension/src/utils/commonUtils.ts 80.62% <100.00%> (+1.10%) ⬆️
...ages/vscode-extension/src/utils/fileSystemUtils.ts 100.00% <100.00%> (ø)
...kages/vscode-extension/src/utils/migrationUtils.ts 100.00% <100.00%> (ø)
... and 4 more

Copy link
Contributor

@tecton tecton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also update codeowner file for new files later.

@yiqing-zhao yiqing-zhao merged commit fa1ce1f into dev Jun 11, 2024
19 checks passed
@yiqing-zhao yiqing-zhao deleted the yiqingzhao/globalVar-handlers branch June 11, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants