Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(sme): use featureFlagManager instead of global function #11785

Merged
merged 5 commits into from
Jun 7, 2024

Conversation

SLdragon
Copy link
Contributor

@SLdragon SLdragon commented Jun 6, 2024

@SLdragon SLdragon requested a review from tecton as a code owner June 6, 2024 06:32
@SLdragon SLdragon requested a review from hund030 as a code owner June 6, 2024 06:50
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.45%. Comparing base (8b61126) to head (5712f72).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #11785      +/-   ##
==========================================
- Coverage   88.45%   88.45%   -0.01%     
==========================================
  Files         530      530              
  Lines       32484    32480       -4     
  Branches     6385     6337      -48     
==========================================
- Hits        28733    28729       -4     
  Misses       1817     1817              
  Partials     1934     1934              
Files Coverage Δ
packages/fx-core/src/common/featureFlags.ts 96.22% <ø> (-0.27%) ⬇️
...ackages/fx-core/src/component/coordinator/index.ts 87.57% <100.00%> (ø)
...core/src/component/driver/oauth/utility/utility.ts 97.56% <100.00%> (ø)
...src/component/generator/copilotPlugin/generator.ts 89.75% <100.00%> (ø)
...re/src/component/generator/copilotPlugin/helper.ts 93.39% <100.00%> (ø)
packages/fx-core/src/question/create.ts 93.43% <ø> (ø)

@SLdragon SLdragon requested a review from huimiu June 7, 2024 02:12
@SLdragon SLdragon merged commit 6e69e41 into dev Jun 7, 2024
19 checks passed
@SLdragon SLdragon deleted the rentu-update66 branch June 7, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants