-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate office xml addin generator #11714
Merged
1openwindow
merged 16 commits into
OfficeDev:dev
from
GavinGu07:user/gaingu/xml_create_migration
Jun 21, 2024
Merged
refactor: migrate office xml addin generator #11714
1openwindow
merged 16 commits into
OfficeDev:dev
from
GavinGu07:user/gaingu/xml_create_migration
Jun 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gaingu/xml_create_migration
…gaingu/xml_create_migration
jayzhang
reviewed
May 28, 2024
packages/vscode-extension/src/officeChat/commands/create/helper.ts
Outdated
Show resolved
Hide resolved
…gaingu/xml_create_migration
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #11714 +/- ##
=======================================
Coverage 88.97% 88.97%
=======================================
Files 551 553 +2
Lines 33034 32953 -81
Branches 6460 6388 -72
=======================================
- Hits 29391 29319 -72
+ Misses 1706 1702 -4
+ Partials 1937 1932 -5
|
jayzhang
previously approved these changes
Jun 14, 2024
ZYUN-MSFT
approved these changes
Jun 18, 2024
…gaingu/xml_create_migration
GavinGu07
requested review from
1openwindow,
HuihuiWu-Microsoft,
nliu-ms,
tecton,
xzf0587,
LongOddCode,
yuqizhou77,
yukun-dong,
hund030 and
JerryYangKai
as code owners
June 20, 2024 08:23
GavinGu07
requested review from
eriolchan,
timngmsft,
sffamily,
therealjohn and
supkasar
as code owners
June 20, 2024 08:23
jayzhang
approved these changes
Jun 21, 2024
supkasar
approved these changes
Jun 21, 2024
1openwindow
approved these changes
Jun 21, 2024
JerryYangKai
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the office xml add-in creation logic to vscode-extension/officeChat