Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate office xml addin generator #11714

Merged
merged 16 commits into from
Jun 21, 2024

Conversation

GavinGu07
Copy link
Contributor

Migrate the office xml add-in creation logic to vscode-extension/officeChat

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 90.12346% with 8 lines in your changes missing coverage. Please review.

Project coverage is 88.97%. Comparing base (2b135cc) to head (91c2e9e).
Report is 2 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #11714   +/-   ##
=======================================
  Coverage   88.97%   88.97%           
=======================================
  Files         551      553    +2     
  Lines       33034    32953   -81     
  Branches     6460     6388   -72     
=======================================
- Hits        29391    29319   -72     
+ Misses       1706     1702    -4     
+ Partials     1937     1932    -5     
Files Coverage Δ
...ackages/fx-core/src/component/coordinator/index.ts 87.37% <100.00%> (-0.15%) ⬇️
...-core/src/component/generator/generatorProvider.ts 100.00% <ø> (ø)
...e/src/component/generator/officeAddin/generator.ts 94.91% <100.00%> (-0.05%) ⬇️
...omponent/generator/officeXMLAddin/projectConfig.ts 100.00% <ø> (ø)
packages/fx-core/src/index.ts 100.00% <100.00%> (ø)
packages/fx-core/src/question/constants.ts 95.17% <100.00%> (-0.97%) ⬇️
...-core/src/question/options/CreateProjectOptions.ts 100.00% <ø> (ø)
...extension/src/officeChat/commands/create/helper.ts 99.06% <100.00%> (-0.01%) ⬇️
...ds/create/officeXMLAddinGenerator/projectConfig.ts 100.00% <100.00%> (ø)
...mmands/create/officeXMLAddinGenerator/generator.ts 92.85% <92.85%> (ø)
... and 1 more

... and 5 files with indirect coverage changes

jayzhang
jayzhang previously approved these changes Jun 14, 2024
@1openwindow 1openwindow merged commit 685c77e into OfficeDev:dev Jun 21, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants