perf(type-b): update add new api logic to support oauth #11515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SLdragon
requested review from
jayzhang,
xzf0587,
LongOddCode,
hund030,
nliu-ms,
timngmsft,
sffamily,
therealjohn and
supkasar
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #11515 +/- ##
========================================
Coverage 88.19% 88.19%
========================================
Files 535 536 +1
Lines 32146 32191 +45
Branches 6351 6202 -149
========================================
+ Hits 28350 28392 +42
Misses 1876 1876
- Partials 1920 1923 +3
|
KennethBWSong
previously approved these changes
Apr 30, 2024
supkasar
reviewed
Apr 30, 2024
| @@ -562,6 +562,7 @@ | |||
| "core.summary.createdEnvFile": "Environment file was created at", | |||
| "core.copilot.addAPI.success": "%s have(has) been successfully added to %s", | |||
| "core.copilot.addAPI.InjectAPIKeyActionFailed": "Inject API key action to teamsapp.yaml file failed, please make sure that file contains teamsApp/create action in provision section.", | |||
| "core.copilot.addAPI.InjectOAuthActionFailed": "Inject OAuth action to teamsapp.yaml file failed, please make sure that file contains teamsApp/create action in provision section.", | |||
There was a problem hiding this comment.
Revised: Inject OAuth action to teamsapp.yaml file unsuccessful, make sure the file contains teamsApp/create action in provision section.
xzf0587
previously approved these changes
Apr 30, 2024
SLdragon
changed the title
KennethBWSong
previously approved these changes
Apr 30, 2024
supkasar
previously approved these changes
Apr 30, 2024
jayzhang
reviewed
Apr 30, 2024
packages/fx-core/src/core/FxCore.ts
Outdated
| @@ -1240,51 +1242,130 @@ export class FxCore { | |||
| return await coordinator.publishInDeveloperPortal(context, inputs as InputsWithProjectPath); | |||
| } | |||
|
|
|||
| hasActionWithName(provisionNode: any, action: string, name: string): any { | |||
There was a problem hiding this comment.
Yaml file related API should moved into a sub-component in src/configManager to avoid code bloating in FxCore.
SLdragon
dismissed stale reviews from supkasar, KennethBWSong, and xzf0587
via
5b19bd1
SLdragon
requested review from
wenytang-ms,
kuojianlu and
Siglud
as code owners
jayzhang
previously approved these changes
Apr 30, 2024
jayzhang
approved these changes
Apr 30, 2024
KennethBWSong
approved these changes
Apr 30, 2024
sffamily
approved these changes
May 6, 2024
nliu-ms
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.