Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validation error when AAD manifest does not contain accessToken property #11131

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

blackchoey
Copy link
Contributor

fix validation error when AAD manifest does not contain accessToken property in optionalClaims

https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/27212864

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.19%. Comparing base (e00bf86) to head (ed3dbd2).
Report is 7 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #11131      +/-   ##
==========================================
+ Coverage   87.16%   87.19%   +0.02%     
==========================================
  Files         457      457              
  Lines       27638    27640       +2     
  Branches     5561     5554       -7     
==========================================
+ Hits        24092    24100       +8     
  Misses       1778     1778              
+ Partials     1768     1762       -6     
Files Coverage Δ
.../component/driver/aad/utility/aadManifestHelper.ts 83.33% <100.00%> (ø)

... and 1 file with indirect coverage changes

@blackchoey blackchoey merged commit adbffcd into dev Mar 19, 2024
19 checks passed
@blackchoey blackchoey deleted the chyuan/fix-aad-manifest-validation branch March 19, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants