Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(spec-parser): add isRequired support for command params #11106

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

SLdragon
Copy link
Contributor

@SLdragon SLdragon commented Mar 18, 2024

manifest update to support isRequired in command parameters: microsoft/json-schemas@9d34df4

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.16%. Comparing base (d1a09e2) to head (0c78adf).
Report is 3 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #11106   +/-   ##
=======================================
  Coverage   87.16%   87.16%           
=======================================
  Files         457      457           
  Lines       27620    27622    +2     
  Branches     5560     5560           
=======================================
+ Hits        24074    24076    +2     
  Misses       1778     1778           
  Partials     1768     1768           
Files Coverage Δ
packages/manifest/src/manifest.ts 100.00% <ø> (ø)
packages/spec-parser/src/interfaces.ts 100.00% <ø> (ø)
packages/spec-parser/src/utils.ts 94.73% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

@SLdragon SLdragon requested a review from yuqizhou77 March 18, 2024 06:20
@SLdragon SLdragon merged commit 88ba4be into dev Mar 18, 2024
25 checks passed
@SLdragon SLdragon deleted the rentu-update318 branch March 18, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants