Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: api me with aad auth template #11092

Merged
merged 7 commits into from
Mar 19, 2024
Merged

feat: api me with aad auth template #11092

merged 7 commits into from
Mar 19, 2024

Conversation

huimiu
Copy link
Member

@huimiu huimiu commented Mar 15, 2024

https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/25150693

Add a new API message extension template to support AAD auth.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.16%. Comparing base (f9f936c) to head (3ef2c3d).
Report is 88 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #11092      +/-   ##
==========================================
+ Coverage   87.00%   87.16%   +0.15%     
==========================================
  Files         451      457       +6     
  Lines       26783    27623     +840     
  Branches     5376     5560     +184     
==========================================
+ Hits        23303    24077     +774     
- Misses       1758     1778      +20     
- Partials     1722     1768      +46     

see 48 files with indirect coverage changes

@huimiu huimiu marked this pull request as ready for review March 15, 2024 02:33
Copy link
Contributor

@hund030 hund030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any source code difference from no-auth api me template? Could we consider merge them into one template?

@huimiu
Copy link
Member Author

huimiu commented Mar 18, 2024

Is there any source code difference from no-auth api me template? Could we consider merge them into one template?

The manifest, README, YML, and Bicep files differ from templates without auth. Do you think it might be complicated to generate different templates through variables? Should we merge them into one template?

@huimiu huimiu merged commit 46de7ac into dev Mar 19, 2024
19 checks passed
@huimiu huimiu deleted the hui/api-me-sso branch March 19, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants