-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SPFx add web part handling version #10514
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #10514 +/- ##
==========================================
+ Coverage 86.60% 86.78% +0.17%
==========================================
Files 448 450 +2
Lines 26235 26421 +186
Branches 5235 5280 +45
==========================================
+ Hits 22722 22930 +208
+ Misses 1803 1771 -32
- Partials 1710 1720 +10
|
yuqizhou77
requested review from
HuihuiWu-Microsoft,
nliu-ms,
jayzhang,
timngmsft,
sffamily,
therealjohn and
MSFT-yiz
as code owners
December 13, 2023 08:25
yuqizhou77
force-pushed
the
yuqzho/add-webpart
branch
from
December 13, 2023 08:49
310e157
to
c82e1de
Compare
refactor: telemetry refactor: more refactor: minor refactor: cli test: ut test: ut test: ut1 test: ut2 test: ut3 test: ut test: ut test: ut refactor: minor
yuqizhou77
force-pushed
the
yuqzho/add-webpart
branch
from
December 13, 2023 08:50
c82e1de
to
b9f2ce9
Compare
nliu-ms
previously approved these changes
Dec 14, 2023
sffamily
reviewed
Dec 14, 2023
sffamily
approved these changes
Dec 14, 2023
nliu-ms
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature 26007373: SPFx add web part by defaut using latest version which bring version mismatch to the original project.
When adding web part, we compare solution version, version of generator installed globally by the user and the version of generator installed locally by TTK, and try to select the package which is in the same version with solution version to continue. If we cannot find, then we will confirm with users to install/upgrade/continue with inconsistent version.
Confirm with user if need to install local dependencies
Confirm with user if need to upgrade local dependencies
Confirm with user to continue
TODO: