perf(apikey): add question model for api key #10267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #10267 +/- ##
==========================================
+ Coverage 86.15% 86.20% +0.04%
==========================================
Files 442 442
Lines 25516 25555 +39
Branches 5009 5016 +7
==========================================
+ Hits 21984 22030 +46
+ Misses 1837 1831 -6
+ Partials 1695 1694 -1
|
KennethBWSong
force-pushed
the
bowsong/api_key_question
branch
from
296735f to
b361fd0
Compare
KennethBWSong
requested review from
timngmsft,
sffamily,
therealjohn,
SLdragon,
adashen,
jayzhang,
xzf0587,
hund030,
LongOddCode,
yuqizhou77 and
tecton
as code owners
jayzhang
reviewed
Nov 2, 2023
| @@ -7,9 +7,12 @@ import { TOOLS } from "../../core/globalVars"; | |||
| import { QuestionNodes, questionNodes } from "../../question"; | |||
| import { traverse } from "../../ui/visitor"; | |||
|
|
|||
| export function QuestionMW(key: keyof QuestionNodes): Middleware { | |||
| export function QuestionMW(key: keyof QuestionNodes, fromAction = false): Middleware { | |||
| return async (ctx: HookContext, next: NextFunction) => { | |||
| const inputs = ctx.arguments[0] as Inputs; | |||
There was a problem hiding this comment.
if fromAction is true, the inputs here is DriverContext, is there any issue if we use it as Inputs type?
There was a problem hiding this comment.
Seems no error when building and running. Do you think we need to mock an input and set platform, xxx into it?
SLdragon
previously approved these changes
Nov 2, 2023
jayzhang
previously approved these changes
Nov 3, 2023
sffamily
previously approved these changes
Nov 3, 2023
| @@ -293,6 +293,8 @@ | |||
| "core.createProjectQuestion.apiSpecInputUrl.label": "Enter OpenAPI Description Document Location", | |||
| "core.createProjectQuestion.OpenAIPluginDomain": "OpenAI Plugin Manifest", | |||
| "core.createProjectQuestion.OpenAIPluginDomain.placeholder": "Enter your website domain or manifest URL", | |||
| "core.createaProjectQuestion.ApiKey": "Client secret for Api key in OpenAPI spec", | |||
There was a problem hiding this comment.
Api -> API
spec -> specification
There was a problem hiding this comment.
Updated, thanks!
| @@ -293,6 +293,8 @@ | |||
| "core.createProjectQuestion.apiSpecInputUrl.label": "Enter OpenAPI Description Document Location", | |||
| "core.createProjectQuestion.OpenAIPluginDomain": "OpenAI Plugin Manifest", | |||
| "core.createProjectQuestion.OpenAIPluginDomain.placeholder": "Enter your website domain or manifest URL", | |||
| "core.createaProjectQuestion.ApiKey": "Client secret for Api key in OpenAPI spec", | |||
| "core.createProjectQuestion.invalidApiKey.message": "Client secret is invalid. Length of secret should >= 10 and <= 128", | |||
There was a problem hiding this comment.
Length -> The length
should -> should be
There was a problem hiding this comment.
Updated, thanks!
sffamily
reviewed
Nov 3, 2023
sffamily
approved these changes
Nov 3, 2023
SLdragon
approved these changes
Nov 3, 2023
jayzhang
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.