Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: truncate app name to avoid import spfx failure #10210

Merged

Conversation

HuihuiWu-Microsoft
Copy link
Contributor

jayzhang
jayzhang previously approved these changes Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #10210 (f992934) into dev (041c93f) will decrease coverage by 0.01%.
Report is 4 commits behind head on dev.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #10210      +/-   ##
==========================================
- Coverage   91.94%   91.93%   -0.01%     
==========================================
  Files         453      453              
  Lines       26278    26269       -9     
  Branches     5055     5057       +2     
==========================================
- Hits        24160    24151       -9     
  Misses       1876     1876              
  Partials      242      242              
Files Coverage Δ
...core/src/component/generator/spfx/spfxGenerator.ts 93.06% <100.00%> (+0.10%) ⬆️
...re/src/component/generator/spfx/utils/constants.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@HuihuiWu-Microsoft HuihuiWu-Microsoft merged commit c9c564e into OfficeDev:dev Oct 27, 2023
@HuihuiWu-Microsoft HuihuiWu-Microsoft deleted the fix-appname-exceed branch October 27, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants