perf(spec-parser): treat required + default parameter as optional parameter #10009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #10009 +/- ##
==========================================
+ Coverage 85.86% 85.94% +0.07%
==========================================
Files 445 445
Lines 25493 25533 +40
Branches 4870 4883 +13
==========================================
+ Hits 21890 21944 +54
+ Misses 1885 1874 -11
+ Partials 1718 1715 -3
|
yuqizhou77
previously approved these changes
Sep 21, 2023
adashen
reviewed
Sep 21, 2023
| if ( | ||
| schema.type !== "boolean" && | ||
| schema.type !== "string" && | ||
| schema.type !== "number" && | ||
| schema.type !== "integer" | ||
| ) { | ||
| if (param.required) { | ||
| if (param.required && schema.default === undefined) { |
There was a problem hiding this comment.
can we have a utility method to extract this logic?
adashen
approved these changes
Sep 21, 2023
yuqizhou77
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 25203352: [API ME] Treat required + default parameter as optional when list supported apis