Skip to content

Commit

Permalink
test: remove node version check
Browse files Browse the repository at this point in the history
  • Loading branch information
hellyzh committed Jun 21, 2024
1 parent 5c16a11 commit b85078d
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 174 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,12 @@ import {
inputFolderPath,
} from "../../utils/vscodeOperation";
import { it } from "../../utils/it";
import { getNodeVersion } from "../../utils/getNodeVersion";
import * as os from "os";

describe("New project Tests", function () {
this.timeout(Timeout.testCase);
let treeViewTestContext: TreeViewTestContext;
let testRootFolder: string;
let nodeVersion: string | null;
const warnMsg =
"App name needs to begin with letters, include minimum two letters or digits, and exclude certain special characters.";

Expand All @@ -33,7 +31,6 @@ describe("New project Tests", function () {
this.timeout(Timeout.prepareTestCase);
treeViewTestContext = new TreeViewTestContext("treeview");
testRootFolder = treeViewTestContext.testRootFolder;
nodeVersion = await getNodeVersion();
await treeViewTestContext.before();
});

Expand Down
Original file line number Diff line number Diff line change
@@ -1,20 +1,18 @@
/**
* @author Darren Miller <[email protected]>
*/
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT license.

import * as path from "path";
import * as fs from "fs-extra";
import { expect } from "chai";
import { Timeout } from "../../utils/constants";
import { TreeViewTestContext } from "./treeviewContext";
import { createNewProject } from "../../utils/vscodeOperation";
import { it } from "../../utils/it";
import { getNodeVersion } from "../../utils/getNodeVersion";

describe("New project Tests", function () {
this.timeout(Timeout.testCase);
let treeViewTestContext: TreeViewTestContext;
let testRootFolder: string;
let nodeVersion: string | null;
const appNameCopySuffix = "copy";
let newAppFolderName: string;
let projectPath: string;
Expand All @@ -24,7 +22,6 @@ describe("New project Tests", function () {
this.timeout(Timeout.prepareTestCase);
treeViewTestContext = new TreeViewTestContext("treeview");
testRootFolder = treeViewTestContext.testRootFolder;
nodeVersion = await getNodeVersion();
await treeViewTestContext.before();
});

Expand Down
Original file line number Diff line number Diff line change
@@ -1,20 +1,18 @@
/**
* @author Helly Zhang <[email protected]>
*/
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT license.

import * as path from "path";
import * as fs from "fs-extra";
import { expect } from "chai";
import { Timeout } from "../../utils/constants";
import { TreeViewTestContext } from "./treeviewContext";
import { createNewProject } from "../../utils/vscodeOperation";
import { it } from "../../utils/it";
import { getNodeVersion } from "../../utils/getNodeVersion";

describe("New project Tests", function () {
this.timeout(Timeout.testCase);
let treeViewTestContext: TreeViewTestContext;
let testRootFolder: string;
let nodeVersion: string | null;
const appNameCopySuffix = "copy";
let newAppFolderName: string;
let projectPath: string;
Expand All @@ -24,7 +22,6 @@ describe("New project Tests", function () {
this.timeout(Timeout.prepareTestCase);
treeViewTestContext = new TreeViewTestContext("treeview");
testRootFolder = treeViewTestContext.testRootFolder;
nodeVersion = await getNodeVersion();
await treeViewTestContext.before();
});

Expand Down
Original file line number Diff line number Diff line change
@@ -1,20 +1,18 @@
/**
* @author Helly Zhang <[email protected]>
*/
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT license.

import * as path from "path";
import * as fs from "fs-extra";
import { expect } from "chai";
import { Timeout } from "../../utils/constants";
import { TreeViewTestContext } from "./treeviewContext";
import { createNewProject } from "../../utils/vscodeOperation";
import { it } from "../../utils/it";
import { getNodeVersion } from "../../utils/getNodeVersion";

describe("New project Tests", function () {
this.timeout(Timeout.testCase);
let treeViewTestContext: TreeViewTestContext;
let testRootFolder: string;
let nodeVersion: string | null;
const appNameCopySuffix = "copy";
let newAppFolderName: string;
let projectPath: string;
Expand All @@ -24,7 +22,6 @@ describe("New project Tests", function () {
this.timeout(Timeout.prepareTestCase);
treeViewTestContext = new TreeViewTestContext("treeview");
testRootFolder = treeViewTestContext.testRootFolder;
nodeVersion = await getNodeVersion();
await treeViewTestContext.before();
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,15 @@ import { TreeViewTestContext, zipAppPackage } from "./treeviewContext";
import { createEnv } from "../remotedebug/remotedebugContext";
import { Timeout, Notification } from "../../utils/constants";
import { it } from "../../utils/it";
import { getNodeVersion } from "../../utils/getNodeVersion";

describe("Execute Build Teams Package", function () {
this.timeout(Timeout.testCase);
let treeViewTestContext: TreeViewTestContext;
let nodeVersion: string | null;

beforeEach(async function () {
// ensure workbench is ready
this.timeout(Timeout.prepareTestCase);
treeViewTestContext = new TreeViewTestContext("treeview");
nodeVersion = await getNodeVersion();
console.log(`Node version is ${nodeVersion}`);
await treeViewTestContext.before();
});

Expand Down
149 changes: 0 additions & 149 deletions packages/tests/src/utils/getNodeVersion.ts

This file was deleted.

0 comments on commit b85078d

Please sign in to comment.