test: fix can\'t find sample page element (#11857)

* test: fix can\'t find sample page element --------- Co-authored-by: Ivan_Chen <[email protected]>
OfficeDev · Jun 19, 2024 · a9b9885 · a9b9885
1 parent ec004ad
commit a9b9885
Show file tree

Hide file tree

Showing 4 changed files with 153 additions and 101 deletions.
diff --git a/packages/tests/src/ui-test/samples/sample-localdebug-contact-exporter.test.ts b/packages/tests/src/ui-test/samples/sample-localdebug-contact-exporter.test.ts
@@ -23,15 +23,7 @@ class ContactExporterTestCase extends CaseFactory {
     sampledebugContext: SampledebugContext,
     teamsAppId: string
   ): Promise<Page> {
-    return await reopenPage(
-      sampledebugContext.context!,
-      teamsAppId,
-      Env.username,
-      Env.password,
-      undefined,
-      true,
-      true
-    );
+    return await reopenPage(sampledebugContext.context!, teamsAppId);
   }
 }
 

diff --git a/packages/tests/src/ui-test/samples/sample-localdebug-npm-search.test.ts b/packages/tests/src/ui-test/samples/sample-localdebug-npm-search.test.ts
@@ -9,20 +9,27 @@ import { Page } from "playwright";
 import { TemplateProject, LocalDebugTaskLabel } from "../../utils/constants";
 import { validateNpm } from "../../utils/playwrightOperation";
 import { CaseFactory } from "./sampleCaseFactory";
+import { SampledebugContext } from "./sampledebugContext";
 
 class NpmSearchTestCase extends CaseFactory {
   override async onValidate(
     page: Page,
-    options?: { npmName: string }
+    options?: { npmName: string; context: SampledebugContext }
   ): Promise<void> {
-    return await validateNpm(page, { npmName: options?.npmName });
+    return await validateNpm(page, {
+      npmName: options?.npmName,
+      appName: options?.context.appName.substring(0, 10) || "",
+    });
   }
 
   override async onCliValidate(
     page: Page,
-    options?: { npmName: string }
+    options?: { npmName: string; context: SampledebugContext }
   ): Promise<void> {
-    return await validateNpm(page, { npmName: options?.npmName });
+    return await validateNpm(page, {
+      npmName: options?.npmName,
+      appName: options?.context.appName.substring(0, 10) || "",
+    });
   }
 }
 

diff --git a/packages/tests/src/ui-test/samples/sample-remotedebug-npm-search.test.ts b/packages/tests/src/ui-test/samples/sample-remotedebug-npm-search.test.ts
@@ -9,20 +9,17 @@ import { Page } from "playwright";
 import { TemplateProject } from "../../utils/constants";
 import { validateNpm } from "../../utils/playwrightOperation";
 import { CaseFactory } from "./sampleCaseFactory";
+import { SampledebugContext } from "./sampledebugContext";
 
 class NpmSearchTestCase extends CaseFactory {
   override async onValidate(
     page: Page,
-    options?: { npmName: string }
+    options?: { npmName: string; context: SampledebugContext }
   ): Promise<void> {
-    return await validateNpm(page, { npmName: options?.npmName });
-  }
-
-  override async onCliValidate(
-    page: Page,
-    options?: { npmName: string }
-  ): Promise<void> {
-    return await validateNpm(page, { npmName: options?.npmName });
+    return await validateNpm(page, {
+      npmName: options?.npmName,
+      appName: options?.context.appName.substring(0, 10) || "",
+    });
   }
 }
 
@@ -32,5 +29,5 @@ new NpmSearchTestCase(
   "[email protected]",
   "dev",
   [],
-  { npmName: "axios", debug: "ttk" }
+  { npmName: "axios" }
 ).test();