Skip to content

Commit

Permalink
fix: update TAB_HOSTNAME in manifest and local config files (#11813)
Browse files Browse the repository at this point in the history
  • Loading branch information
huimiu authored Jun 13, 2024
1 parent 7030660 commit 8afd5ce
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 4 deletions.
2 changes: 1 addition & 1 deletion templates/csharp/sso-tab-ssr/appPackage/manifest.json.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"messageTeamMembers"
],
"validDomains": [
"${{TAB_DOMAIN}}"
"${{TAB_HOSTNAME}}"
],
"webApplicationInfo": {
"id": "${{AAD_APP_CLIENT_ID}}",
Expand Down
1 change: 1 addition & 0 deletions templates/csharp/sso-tab-ssr/infra/azure.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,5 @@ resource webAppConfig 'Microsoft.Web/sites/config@2021-02-01' = {
// The output will be persisted in .env.{envName}. Visit https://aka.ms/teamsfx-actions/arm-deploy for more details.
output TAB_AZURE_APP_SERVICE_RESOURCE_ID string = webApp.id
output TAB_DOMAIN string = webApp.properties.defaultHostName
output TAB_HOSTNAME string = webApp.properties.defaultHostName
output TAB_ENDPOINT string = 'https://${webApp.properties.defaultHostName}'
3 changes: 2 additions & 1 deletion templates/csharp/sso-tab-ssr/teamsapp.local.yml.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ provision:
- uses: script
with:
run:
echo "::set-teamsfx-env TAB_DOMAIN=localhost";
echo "::set-teamsfx-env TAB_HOSTNAME=localhost";
echo "::set-teamsfx-env TAB_DOMAIN=localhost:44302";
echo "::set-teamsfx-env TAB_ENDPOINT=https://localhost:44302";

# Generate runtime appsettings to JSON file
Expand Down
2 changes: 1 addition & 1 deletion templates/csharp/sso-tab/appPackage/manifest.json.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"messageTeamMembers"
],
"validDomains": [
"${{TAB_DOMAIN}}"
"${{TAB_HOSTNAME}}"
],
"webApplicationInfo": {
"id": "${{AAD_APP_CLIENT_ID}}",
Expand Down
1 change: 1 addition & 0 deletions templates/csharp/sso-tab/infra/azure.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,5 @@ resource webAppConfig 'Microsoft.Web/sites/config@2021-02-01' = {
// The output will be persisted in .env.{envName}. Visit https://aka.ms/teamsfx-actions/arm-deploy for more details.
output TAB_AZURE_APP_SERVICE_RESOURCE_ID string = webApp.id
output TAB_DOMAIN string = webApp.properties.defaultHostName
output TAB_HOSTNAME string = webApp.properties.defaultHostName
output TAB_ENDPOINT string = 'https://${webApp.properties.defaultHostName}'
3 changes: 2 additions & 1 deletion templates/csharp/sso-tab/teamsapp.local.yml.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ provision:
- uses: script
with:
run:
echo "::set-teamsfx-env TAB_DOMAIN=localhost";
echo "::set-teamsfx-env TAB_HOSTNAME=localhost";
echo "::set-teamsfx-env TAB_DOMAIN=localhost:44302";
echo "::set-teamsfx-env TAB_ENDPOINT=https://localhost:44302";

# Generate runtime appsettings to JSON file
Expand Down

0 comments on commit 8afd5ce

Please sign in to comment.