-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract code snippets, move ISO references to snippets, update msdn links to learn.microsoft #305
Conversation
Learn Build status updates of commit b0504f7: 💡 Validation status: suggestionsThis comment lists only the first 25 files in the pull request. docs/general/how-to-add-a-new-document-part-to-a-package.md
docs/general/how-to-copy-the-contents-of-an-open-xml-package-part-to-a-document-part-in-a-dif.md
docs/general/how-to-create-a-package.md
docs/general/how-to-get-the-contents-of-a-document-part-from-a-package.md
docs/general/how-to-remove-a-document-part-from-a-package.md
docs/general/how-to-replace-the-theme-part-in-a-word-processing-document.md
docs/general/how-to-search-and-replace-text-in-a-document-part.md
docs/general/introduction-to-markup-compatibility.md
This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
Learn Build status updates of commit 5118ad0: 💡 Validation status: suggestionsThis comment lists only the first 25 files in the pull request. docs/general/how-to-add-a-new-document-part-to-a-package.md
docs/general/how-to-copy-the-contents-of-an-open-xml-package-part-to-a-document-part-in-a-dif.md
docs/general/how-to-create-a-package.md
docs/general/how-to-get-the-contents-of-a-document-part-from-a-package.md
docs/general/how-to-remove-a-document-part-from-a-package.md
docs/general/how-to-replace-the-theme-part-in-a-word-processing-document.md
docs/general/how-to-search-and-replace-text-in-a-document-part.md
docs/general/introduction-to-markup-compatibility.md
This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM. @AlfredHellstern what are your thoughts for the comments about ISO/IEC 29500
text?
@@ -78,7 +78,7 @@ long as you use **using**. | |||
-------------------------------------------------------------------------------- | |||
## The Theme Part | |||
The theme part contains information about the color, font, and format of | |||
a document. It is defined in the [ISO/IEC 29500](https://www.iso.org/standard/71691.html) specification as | |||
a document. It is defined in the [!include[ISO/IEC 29500 URL](../includes/iso-iec-29500-link.md)] specification as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a document. It is defined in the [!include[ISO/IEC 29500 URL](../includes/iso-iec-29500-link.md)] specification as | |
a document. It is defined in the [!include[ISO/IEC 29500](../includes/iso-iec-29500-link.md)] specification as |
does it need the "URL" as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this to differentiate it from the version snippet. It does not show in the documentation, it's only the description for screen readers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh that makes sense
@@ -110,7 +110,7 @@ is stored in the ZIP item theme/theme1.xml: | |||
``` | |||
|
|||
|
|||
© ISO/IEC29500: 2008. | |||
© [!include[ISO/IEC 29500 version](../includes/iso-iec-29500-version.md)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
© [!include[ISO/IEC 29500 version](../includes/iso-iec-29500-version.md)] | |
© [!include[ISO/IEC 29500](../includes/iso-iec-29500-version.md)] |
same as above - it seems like a consistent ISO/IEC 29500
would be ideal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why the actual version is its own include, since either way something will have to be updated once the next version of 29500 is published.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why the actual version is its own include, since either way something will have to be updated once the next version of 29500 is published.
If it is it's own snippet, we will only need to update it once instead of in a lot of different files.
@mikeebowen do a replace for all the learn.microsoft.com prefixes and just have a relative link |
Learn Build status updates of commit c9dac65: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. For any questions, please:
|
closes Extract code snippets from working-with-wordprocessingml-tables.md #265
closes Extract code snippets from working-with-runs.md #264
closes Extract code snippets from working-with-paragraphs.md #263
closes xmlns should use http instead of https in multiple files #299
closes Extract code snippets from structure-of-a-wordprocessingml-document.md #262
closes Ensure we're not referencing specific versions #301
closes Extract code snippets from how-to-validate-a-word-processing-document.md #261
closes Extract code snippets from how-to-set-the-font-for-a-text-run.md #239
closes Convert MSDN links to microsoft.learn #302
closes Extract ISO/IEC 29500 references to snippet #304