-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move samples to .cs and .vb files #167
Conversation
This reverts commit 513a3d8.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
remove duplicated section
This comment was marked as outdated.
This comment was marked as outdated.
@mikeebowen I had disabled the nullable support for now (since the samples were old and we can do code clean up in a separate change) via https://github.com/OfficeDev/open-xml-docs/blob/main/samples/Directory.Build.props. |
One of the changes to the samples that I forgot to document (but visible in the ones I updated) is switching them so you can just |
also, I had intentionally set up the script to ask for the name so it can be shortened and concise - I'm not sure about just taking the title "how do i ..." - can you shorten them so that there's not so many extra words? |
Learn Build status updates of commit e2b9a6d: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. For any questions, please:
|
Learn Build status updates of commit 84c4384: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. For any questions, please:
|
Learn Build status updates of commit e2b9a6d: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. For any questions, please:
|
LGTM! Thanks @mikeebowen |
This pull moves .vb and .cs samples to their own files and fixes some formatting and linting issues in the samples.