Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move samples to .cs and .vb files #167

Merged
merged 15 commits into from
Oct 31, 2023
Merged

Move samples to .cs and .vb files #167

merged 15 commits into from
Oct 31, 2023

Conversation

mikeebowen
Copy link
Collaborator

This pull moves .vb and .cs samples to their own files and fixes some formatting and linting issues in the samples.

@learn-build-service-prod

This comment was marked as outdated.

@mikeebowen mikeebowen marked this pull request as draft October 24, 2023 22:19
@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@mikeebowen mikeebowen marked this pull request as ready for review October 24, 2023 22:58
@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 94e0a59:

✅ Validation status: passed

File Status Preview URL Details
docs/how-to-add-custom-ui-to-a-spreadsheet-document.md ✅Succeeded
docs/how-to-add-tables-to-word-processing-documents.md ✅Succeeded
docs/how-to-change-text-in-a-table-in-a-word-processing-document.md ✅Succeeded
docs/how-to-change-the-fill-color-of-a-shape-in-a-presentation.md ✅Succeeded
docs/how-to-change-the-print-orientation-of-a-word-processing-document.md ✅Succeeded
docs/how-to-convert-a-word-processing-document-from-the-docm-to-the-docx-file-format.md ✅Succeeded
docs/how-to-create-and-add-a-character-style-to-a-word-processing-document.md ✅Succeeded
docs/how-to-create-and-add-a-paragraph-style-to-a-word-processing-document.md ✅Succeeded
docs/how-to-create-a-presentation-document-by-providing-a-file-name.md ✅Succeeded
docs/how-to-delete-comments-by-all-or-a-specific-author-in-a-word-processing-document.md ✅Succeeded
docs/how-to-extract-styles-from-a-word-processing-document.md ✅Succeeded
docs/how-to-insert-a-comment-into-a-word-processing-document.md ✅Succeeded
docs/how-to-insert-a-new-worksheet-into-a-spreadsheet.md ✅Succeeded
docs/how-to-insert-a-picture-into-a-word-processing-document.md ✅Succeeded
docs/how-to-insert-a-table-into-a-word-processing-document.md ✅Succeeded
docs/how-to-merge-two-adjacent-cells-in-a-spreadsheet.md ✅Succeeded
docs/how-to-open-a-spreadsheet-document-for-read-only-access.md ✅Succeeded
docs/how-to-open-a-spreadsheet-document-from-a-stream.md ✅Succeeded
docs/how-to-parse-and-read-a-large-spreadsheet.md ✅Succeeded
docs/how-to-remove-hidden-text-from-a-word-processing-document.md ✅Succeeded
docs/how-to-remove-the-headers-and-footers-from-a-word-processing-document.md ✅Succeeded
docs/how-to-replace-the-header-in-a-word-processing-document.md ✅Succeeded
docs/how-to-replace-the-styles-parts-in-a-word-processing-document.md ✅Succeeded
docs/how-to-replace-the-theme-part-in-a-word-processing-document.md ✅Succeeded
docs/how-to-retrieve-a-dictionary-of-all-named-ranges-in-a-spreadsheet.md ✅Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@twsouthwick
Copy link
Collaborator

@mikeebowen I had disabled the nullable support for now (since the samples were old and we can do code clean up in a separate change) via https://github.com/OfficeDev/open-xml-docs/blob/main/samples/Directory.Build.props.

@twsouthwick
Copy link
Collaborator

One of the changes to the samples that I forgot to document (but visible in the ones I updated) is switching them so you can just dotnet run -- [args] to try it out - meaning changing it to be an exe instead of a method. We can do it that in a subsequent change, just FYI

@twsouthwick
Copy link
Collaborator

also, I had intentionally set up the script to ask for the name so it can be shortened and concise - I'm not sure about just taking the title "how do i ..." - can you shorten them so that there's not so many extra words?

@mikeebowen mikeebowen marked this pull request as draft October 26, 2023 17:34
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit e2b9a6d:

✅ Validation status: passed

File Status Preview URL Details
docs/how-to-add-custom-ui-to-a-spreadsheet-document.md ✅Succeeded
docs/how-to-add-tables-to-word-processing-documents.md ✅Succeeded
docs/how-to-change-text-in-a-table-in-a-word-processing-document.md ✅Succeeded
docs/how-to-change-the-fill-color-of-a-shape-in-a-presentation.md ✅Succeeded
docs/how-to-change-the-print-orientation-of-a-word-processing-document.md ✅Succeeded
docs/how-to-convert-a-word-processing-document-from-the-docm-to-the-docx-file-format.md ✅Succeeded
docs/how-to-create-and-add-a-character-style-to-a-word-processing-document.md ✅Succeeded
docs/how-to-create-and-add-a-paragraph-style-to-a-word-processing-document.md ✅Succeeded
docs/how-to-create-a-presentation-document-by-providing-a-file-name.md ✅Succeeded
docs/how-to-delete-comments-by-all-or-a-specific-author-in-a-word-processing-document.md ✅Succeeded
docs/how-to-extract-styles-from-a-word-processing-document.md ✅Succeeded
docs/how-to-insert-a-comment-into-a-word-processing-document.md ✅Succeeded
docs/how-to-insert-a-new-worksheet-into-a-spreadsheet.md ✅Succeeded
docs/how-to-insert-a-picture-into-a-word-processing-document.md ✅Succeeded
docs/how-to-insert-a-table-into-a-word-processing-document.md ✅Succeeded
docs/how-to-merge-two-adjacent-cells-in-a-spreadsheet.md ✅Succeeded
docs/how-to-open-a-spreadsheet-document-for-read-only-access.md ✅Succeeded
docs/how-to-open-a-spreadsheet-document-from-a-stream.md ✅Succeeded
docs/how-to-parse-and-read-a-large-spreadsheet.md ✅Succeeded
docs/how-to-remove-hidden-text-from-a-word-processing-document.md ✅Succeeded
docs/how-to-remove-the-headers-and-footers-from-a-word-processing-document.md ✅Succeeded
docs/how-to-replace-the-header-in-a-word-processing-document.md ✅Succeeded
docs/how-to-replace-the-styles-parts-in-a-word-processing-document.md ✅Succeeded
docs/how-to-replace-the-theme-part-in-a-word-processing-document.md ✅Succeeded
docs/how-to-retrieve-a-dictionary-of-all-named-ranges-in-a-spreadsheet.md ✅Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 84c4384:

✅ Validation status: passed

File Status Preview URL Details
docs/how-to-add-custom-ui-to-a-spreadsheet-document.md ✅Succeeded
docs/how-to-add-tables-to-word-processing-documents.md ✅Succeeded
docs/how-to-change-text-in-a-table-in-a-word-processing-document.md ✅Succeeded
docs/how-to-change-the-fill-color-of-a-shape-in-a-presentation.md ✅Succeeded
docs/how-to-change-the-print-orientation-of-a-word-processing-document.md ✅Succeeded
docs/how-to-convert-a-word-processing-document-from-the-docm-to-the-docx-file-format.md ✅Succeeded
docs/how-to-create-and-add-a-character-style-to-a-word-processing-document.md ✅Succeeded
docs/how-to-create-and-add-a-paragraph-style-to-a-word-processing-document.md ✅Succeeded
docs/how-to-create-a-presentation-document-by-providing-a-file-name.md ✅Succeeded
docs/how-to-delete-comments-by-all-or-a-specific-author-in-a-word-processing-document.md ✅Succeeded
docs/how-to-extract-styles-from-a-word-processing-document.md ✅Succeeded
docs/how-to-insert-a-comment-into-a-word-processing-document.md ✅Succeeded
docs/how-to-insert-a-new-worksheet-into-a-spreadsheet.md ✅Succeeded
docs/how-to-insert-a-picture-into-a-word-processing-document.md ✅Succeeded
docs/how-to-insert-a-table-into-a-word-processing-document.md ✅Succeeded
docs/how-to-merge-two-adjacent-cells-in-a-spreadsheet.md ✅Succeeded
docs/how-to-open-a-spreadsheet-document-for-read-only-access.md ✅Succeeded
docs/how-to-open-a-spreadsheet-document-from-a-stream.md ✅Succeeded
docs/how-to-parse-and-read-a-large-spreadsheet.md ✅Succeeded
docs/how-to-remove-hidden-text-from-a-word-processing-document.md ✅Succeeded
docs/how-to-remove-the-headers-and-footers-from-a-word-processing-document.md ✅Succeeded
docs/how-to-replace-the-header-in-a-word-processing-document.md ✅Succeeded
docs/how-to-replace-the-styles-parts-in-a-word-processing-document.md ✅Succeeded
docs/how-to-replace-the-theme-part-in-a-word-processing-document.md ✅Succeeded
docs/how-to-retrieve-a-dictionary-of-all-named-ranges-in-a-spreadsheet.md ✅Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit e2b9a6d:

✅ Validation status: passed

File Status Preview URL Details
docs/how-to-add-custom-ui-to-a-spreadsheet-document.md ✅Succeeded
docs/how-to-add-tables-to-word-processing-documents.md ✅Succeeded
docs/how-to-change-text-in-a-table-in-a-word-processing-document.md ✅Succeeded
docs/how-to-change-the-fill-color-of-a-shape-in-a-presentation.md ✅Succeeded
docs/how-to-change-the-print-orientation-of-a-word-processing-document.md ✅Succeeded
docs/how-to-convert-a-word-processing-document-from-the-docm-to-the-docx-file-format.md ✅Succeeded
docs/how-to-create-and-add-a-character-style-to-a-word-processing-document.md ✅Succeeded
docs/how-to-create-and-add-a-paragraph-style-to-a-word-processing-document.md ✅Succeeded
docs/how-to-create-a-presentation-document-by-providing-a-file-name.md ✅Succeeded
docs/how-to-delete-comments-by-all-or-a-specific-author-in-a-word-processing-document.md ✅Succeeded
docs/how-to-extract-styles-from-a-word-processing-document.md ✅Succeeded
docs/how-to-insert-a-comment-into-a-word-processing-document.md ✅Succeeded
docs/how-to-insert-a-new-worksheet-into-a-spreadsheet.md ✅Succeeded
docs/how-to-insert-a-picture-into-a-word-processing-document.md ✅Succeeded
docs/how-to-insert-a-table-into-a-word-processing-document.md ✅Succeeded
docs/how-to-merge-two-adjacent-cells-in-a-spreadsheet.md ✅Succeeded
docs/how-to-open-a-spreadsheet-document-for-read-only-access.md ✅Succeeded
docs/how-to-open-a-spreadsheet-document-from-a-stream.md ✅Succeeded
docs/how-to-parse-and-read-a-large-spreadsheet.md ✅Succeeded
docs/how-to-remove-hidden-text-from-a-word-processing-document.md ✅Succeeded
docs/how-to-remove-the-headers-and-footers-from-a-word-processing-document.md ✅Succeeded
docs/how-to-replace-the-header-in-a-word-processing-document.md ✅Succeeded
docs/how-to-replace-the-styles-parts-in-a-word-processing-document.md ✅Succeeded
docs/how-to-replace-the-theme-part-in-a-word-processing-document.md ✅Succeeded
docs/how-to-retrieve-a-dictionary-of-all-named-ranges-in-a-spreadsheet.md ✅Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@mikeebowen mikeebowen marked this pull request as ready for review October 26, 2023 21:24
@twsouthwick
Copy link
Collaborator

LGTM! Thanks @mikeebowen

@lindalu-MSFT lindalu-MSFT merged commit 43c80eb into OfficeDev:main Oct 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants