Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit version reference to 2.5 #158

Merged
merged 5 commits into from
Oct 17, 2023

Conversation

twsouthwick
Copy link
Collaborator

@twsouthwick twsouthwick commented Oct 17, 2023

This removes explicit references to version numbers as the text wasn't dependent on it. This also fixed up broken links so the build passes.

Fixes #90
Part of #159

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit a642740:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/how-to-replace-the-styles-parts-in-a-word-processing-document.md ⚠️Warning Details
docs/how-to-calculate-the-sum-of-a-range-of-cells-in-a-spreadsheet-document.md 💡Suggestion Details
docs/how-to-get-worksheet-information-from-a-package.md 💡Suggestion Details
docs/introduction-to-markup-compatibility.md 💡Suggestion Details
docs/open-xml-sdk.md 💡Suggestion Details
docs/structure-of-a-spreadsheetml-document.md 💡Suggestion Details
docs/about-the-open-xml-sdk.md ✅Succeeded
docs/getting-started.md ✅Succeeded
docs/how-do-i.md ✅Succeeded
docs/how-to-accept-all-revisions-in-a-word-processing-document.md ✅Succeeded
docs/how-to-add-a-comment-to-a-slide-in-a-presentation.md ✅Succeeded
docs/how-to-add-a-new-document-part-that-receives-a-relationship-id-to-a-package.md ✅Succeeded
docs/how-to-add-a-new-document-part-to-a-package.md ✅Succeeded
docs/how-to-add-custom-ui-to-a-spreadsheet-document.md ✅Succeeded
docs/how-to-add-tables-to-word-processing-documents.md ✅Succeeded
docs/how-to-apply-a-style-to-a-paragraph-in-a-word-processing-document.md ✅Succeeded
docs/how-to-apply-a-theme-to-a-presentation.md ✅Succeeded
docs/how-to-change-text-in-a-table-in-a-word-processing-document.md ✅Succeeded
docs/how-to-change-the-fill-color-of-a-shape-in-a-presentation.md ✅Succeeded
docs/how-to-change-the-print-orientation-of-a-word-processing-document.md ✅Succeeded
docs/how-to-convert-a-word-processing-document-from-the-docm-to-the-docx-file-format.md ✅Succeeded
docs/how-to-copy-the-contents-of-an-open-xml-package-part-to-a-document-part-in-a-dif.md ✅Succeeded
docs/how-to-create-and-add-a-character-style-to-a-word-processing-document.md ✅Succeeded
docs/how-to-create-and-add-a-paragraph-style-to-a-word-processing-document.md ✅Succeeded
docs/how-to-create-a-package.md ✅Succeeded

This comment lists only the first 25 files in the pull request.

docs/how-to-replace-the-styles-parts-in-a-word-processing-document.md

  • Line 188, Column 1: [Warning: disallowed-html-attribute - See documentation] HTML attribute 'sdata' on tag 'span' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

docs/how-to-calculate-the-sum-of-a-range-of-cells-in-a-spreadsheet-document.md

  • Line 294, Column 295: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: /dotnet/api/system.string.compare?view=net-6.0

docs/how-to-get-worksheet-information-from-a-package.md

  • Line 42, Column 70: [Suggestion: link-broken - See documentation] Link '/dotnet/api/documentformat.openxml.packaging.spreadsheetdocument.open.md' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 115, Column 188: [Suggestion: link-broken - See documentation] Link '/api/documentformat.openxml.openxmlattribute?view=openxml-2.8.1&preserve-view=true' points to a page that doesn't exist. Check the path or URL and update the link.

docs/introduction-to-markup-compatibility.md

  • Line 38, Column 114: [Suggestion: link-broken - See documentation] Link 'https://www.ecma-international.org/publications/files/ECMA-ST/ECMA-376,%20Second%20Edition' points to a page that doesn't exist. Check the path or URL and update the link.

docs/open-xml-sdk.md

  • Line 31, Column 1: [Suggestion: link-broken - See documentation] Link 'https://www.ecma-international.org/publications/standards/Ecma-376.htm' points to a page that doesn't exist. Check the path or URL and update the link.

docs/structure-of-a-spreadsheetml-document.md

  • Line 58, Column 29: [Suggestion: link-broken - See documentation] Link 'https://www.ecma-international.org/publications/standards/Ecma-376.htm' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Links can become broken if there are changes on the target sites. If you think the validation result is a false alarm, please use SiteHelp with option 'Content authoring and publishing -> False alarm on broken link validation' to report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit d75d289:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/how-to-get-worksheet-information-from-a-package.md ⚠️Warning Details
docs/introduction-to-markup-compatibility.md 💡Suggestion Details
docs/open-xml-sdk.md 💡Suggestion Details
docs/structure-of-a-spreadsheetml-document.md 💡Suggestion Details
docs/about-the-open-xml-sdk.md ✅Succeeded
docs/getting-started.md ✅Succeeded
docs/how-do-i.md ✅Succeeded
docs/how-to-accept-all-revisions-in-a-word-processing-document.md ✅Succeeded
docs/how-to-add-a-comment-to-a-slide-in-a-presentation.md ✅Succeeded
docs/how-to-add-a-new-document-part-that-receives-a-relationship-id-to-a-package.md ✅Succeeded
docs/how-to-add-a-new-document-part-to-a-package.md ✅Succeeded
docs/how-to-add-custom-ui-to-a-spreadsheet-document.md ✅Succeeded
docs/how-to-add-tables-to-word-processing-documents.md ✅Succeeded
docs/how-to-apply-a-style-to-a-paragraph-in-a-word-processing-document.md ✅Succeeded
docs/how-to-apply-a-theme-to-a-presentation.md ✅Succeeded
docs/how-to-calculate-the-sum-of-a-range-of-cells-in-a-spreadsheet-document.md ✅Succeeded
docs/how-to-change-text-in-a-table-in-a-word-processing-document.md ✅Succeeded
docs/how-to-change-the-fill-color-of-a-shape-in-a-presentation.md ✅Succeeded
docs/how-to-change-the-print-orientation-of-a-word-processing-document.md ✅Succeeded
docs/how-to-convert-a-word-processing-document-from-the-docm-to-the-docx-file-format.md ✅Succeeded
docs/how-to-copy-the-contents-of-an-open-xml-package-part-to-a-document-part-in-a-dif.md ✅Succeeded
docs/how-to-create-and-add-a-character-style-to-a-word-processing-document.md ✅Succeeded
docs/how-to-create-and-add-a-paragraph-style-to-a-word-processing-document.md ✅Succeeded
docs/how-to-create-a-package.md ✅Succeeded
docs/how-to-create-a-presentation-document-by-providing-a-file-name.md ✅Succeeded

This comment lists only the first 25 files in the pull request.

docs/how-to-get-worksheet-information-from-a-package.md

  • Line 42, Column 253: [Warning: file-not-found - See documentation] Invalid file link: 'dotnet/api/documentformat.openxml.packaging.spreadsheetdocument.open'.
  • Line 42, Column 70: [Suggestion: link-broken - See documentation] Link '/dotnet/api/documentformat.openxml.packaging.spreadsheetdocument.open.md' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 115, Column 169: [Suggestion: link-broken - See documentation] Link '/api/documentformat.openxml.openxmlattribute?preserve-view=true' points to a page that doesn't exist. Check the path or URL and update the link.

docs/introduction-to-markup-compatibility.md

  • Line 38, Column 114: [Suggestion: link-broken - See documentation] Link 'https://www.ecma-international.org/publications/files/ECMA-ST/ECMA-376,%20Second%20Edition' points to a page that doesn't exist. Check the path or URL and update the link.

docs/open-xml-sdk.md

  • Line 31, Column 1: [Suggestion: link-broken - See documentation] Link 'https://www.ecma-international.org/publications/standards/Ecma-376.htm' points to a page that doesn't exist. Check the path or URL and update the link.

docs/structure-of-a-spreadsheetml-document.md

  • Line 58, Column 29: [Suggestion: link-broken - See documentation] Link 'https://www.ecma-international.org/publications/standards/Ecma-376.htm' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Links can become broken if there are changes on the target sites. If you think the validation result is a false alarm, please use SiteHelp with option 'Content authoring and publishing -> False alarm on broken link validation' to report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 9666083:

💡 Validation status: suggestions

File Status Preview URL Details
docs/how-to-get-worksheet-information-from-a-package.md 💡Suggestion Details
docs/introduction-to-markup-compatibility.md 💡Suggestion Details
docs/open-xml-sdk.md 💡Suggestion Details
docs/structure-of-a-spreadsheetml-document.md 💡Suggestion Details
docs/about-the-open-xml-sdk.md ✅Succeeded
docs/getting-started.md ✅Succeeded
docs/how-do-i.md ✅Succeeded
docs/how-to-accept-all-revisions-in-a-word-processing-document.md ✅Succeeded
docs/how-to-add-a-comment-to-a-slide-in-a-presentation.md ✅Succeeded
docs/how-to-add-a-new-document-part-that-receives-a-relationship-id-to-a-package.md ✅Succeeded
docs/how-to-add-a-new-document-part-to-a-package.md ✅Succeeded
docs/how-to-add-custom-ui-to-a-spreadsheet-document.md ✅Succeeded
docs/how-to-add-tables-to-word-processing-documents.md ✅Succeeded
docs/how-to-apply-a-style-to-a-paragraph-in-a-word-processing-document.md ✅Succeeded
docs/how-to-apply-a-theme-to-a-presentation.md ✅Succeeded
docs/how-to-calculate-the-sum-of-a-range-of-cells-in-a-spreadsheet-document.md ✅Succeeded
docs/how-to-change-text-in-a-table-in-a-word-processing-document.md ✅Succeeded
docs/how-to-change-the-fill-color-of-a-shape-in-a-presentation.md ✅Succeeded
docs/how-to-change-the-print-orientation-of-a-word-processing-document.md ✅Succeeded
docs/how-to-convert-a-word-processing-document-from-the-docm-to-the-docx-file-format.md ✅Succeeded
docs/how-to-copy-the-contents-of-an-open-xml-package-part-to-a-document-part-in-a-dif.md ✅Succeeded
docs/how-to-create-and-add-a-character-style-to-a-word-processing-document.md ✅Succeeded
docs/how-to-create-and-add-a-paragraph-style-to-a-word-processing-document.md ✅Succeeded
docs/how-to-create-a-package.md ✅Succeeded
docs/how-to-create-a-presentation-document-by-providing-a-file-name.md ✅Succeeded

This comment lists only the first 25 files in the pull request.

docs/how-to-get-worksheet-information-from-a-package.md

  • Line 42, Column 70: [Suggestion: link-broken - See documentation] Link '/dotnet/api/documentformat.openxml.packaging.spreadsheetdocument.open.md' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 115, Column 150: [Suggestion: link-broken - See documentation] Link '/api/documentformat.openxml.openxmlattribute' points to a page that doesn't exist. Check the path or URL and update the link.

docs/introduction-to-markup-compatibility.md

  • Line 38, Column 114: [Suggestion: link-broken - See documentation] Link 'https://www.ecma-international.org/publications/files/ECMA-ST/ECMA-376,%20Second%20Edition' points to a page that doesn't exist. Check the path or URL and update the link.

docs/open-xml-sdk.md

  • Line 31, Column 1: [Suggestion: link-broken - See documentation] Link 'https://www.ecma-international.org/publications/standards/Ecma-376.htm' points to a page that doesn't exist. Check the path or URL and update the link.

docs/structure-of-a-spreadsheetml-document.md

  • Line 58, Column 29: [Suggestion: link-broken - See documentation] Link 'https://www.ecma-international.org/publications/standards/Ecma-376.htm' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Links can become broken if there are changes on the target sites. If you think the validation result is a false alarm, please use SiteHelp with option 'Content authoring and publishing -> False alarm on broken link validation' to report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit ff0cfcb:

💡 Validation status: suggestions

File Status Preview URL Details
docs/introduction-to-markup-compatibility.md 💡Suggestion Details
docs/about-the-open-xml-sdk.md ✅Succeeded
docs/getting-started.md ✅Succeeded
docs/how-do-i.md ✅Succeeded
docs/how-to-accept-all-revisions-in-a-word-processing-document.md ✅Succeeded
docs/how-to-add-a-comment-to-a-slide-in-a-presentation.md ✅Succeeded
docs/how-to-add-a-new-document-part-that-receives-a-relationship-id-to-a-package.md ✅Succeeded
docs/how-to-add-a-new-document-part-to-a-package.md ✅Succeeded
docs/how-to-add-custom-ui-to-a-spreadsheet-document.md ✅Succeeded
docs/how-to-add-tables-to-word-processing-documents.md ✅Succeeded
docs/how-to-apply-a-style-to-a-paragraph-in-a-word-processing-document.md ✅Succeeded
docs/how-to-apply-a-theme-to-a-presentation.md ✅Succeeded
docs/how-to-calculate-the-sum-of-a-range-of-cells-in-a-spreadsheet-document.md ✅Succeeded
docs/how-to-change-text-in-a-table-in-a-word-processing-document.md ✅Succeeded
docs/how-to-change-the-fill-color-of-a-shape-in-a-presentation.md ✅Succeeded
docs/how-to-change-the-print-orientation-of-a-word-processing-document.md ✅Succeeded
docs/how-to-convert-a-word-processing-document-from-the-docm-to-the-docx-file-format.md ✅Succeeded
docs/how-to-copy-the-contents-of-an-open-xml-package-part-to-a-document-part-in-a-dif.md ✅Succeeded
docs/how-to-create-and-add-a-character-style-to-a-word-processing-document.md ✅Succeeded
docs/how-to-create-and-add-a-paragraph-style-to-a-word-processing-document.md ✅Succeeded
docs/how-to-create-a-package.md ✅Succeeded
docs/how-to-create-a-presentation-document-by-providing-a-file-name.md ✅Succeeded
docs/how-to-create-a-spreadsheet-document-by-providing-a-file-name.md ✅Succeeded
docs/how-to-create-a-word-processing-document-by-providing-a-file-name.md ✅Succeeded
docs/how-to-delete-all-the-comments-by-an-author-from-all-the-slides-in-a-presentatio.md ✅Succeeded

This comment lists only the first 25 files in the pull request.

docs/introduction-to-markup-compatibility.md

  • Line 38, Column 38: [Suggestion: link-broken - See documentation] Link 'https://www.ecma-international.org/wp-content/uploads/ECMA-376-Fifth-Edition-Part-3-Markup-Compatibility-and-Extensibility.zip' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Links can become broken if there are changes on the target sites. If you think the validation result is a false alarm, please use SiteHelp with option 'Content authoring and publishing -> False alarm on broken link validation' to report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 50be13d:

✅ Validation status: passed

File Status Preview URL Details
docs/about-the-open-xml-sdk.md ✅Succeeded
docs/getting-started.md ✅Succeeded
docs/how-do-i.md ✅Succeeded
docs/how-to-accept-all-revisions-in-a-word-processing-document.md ✅Succeeded
docs/how-to-add-a-comment-to-a-slide-in-a-presentation.md ✅Succeeded
docs/how-to-add-a-new-document-part-that-receives-a-relationship-id-to-a-package.md ✅Succeeded
docs/how-to-add-a-new-document-part-to-a-package.md ✅Succeeded
docs/how-to-add-custom-ui-to-a-spreadsheet-document.md ✅Succeeded
docs/how-to-add-tables-to-word-processing-documents.md ✅Succeeded
docs/how-to-apply-a-style-to-a-paragraph-in-a-word-processing-document.md ✅Succeeded
docs/how-to-apply-a-theme-to-a-presentation.md ✅Succeeded
docs/how-to-calculate-the-sum-of-a-range-of-cells-in-a-spreadsheet-document.md ✅Succeeded
docs/how-to-change-text-in-a-table-in-a-word-processing-document.md ✅Succeeded
docs/how-to-change-the-fill-color-of-a-shape-in-a-presentation.md ✅Succeeded
docs/how-to-change-the-print-orientation-of-a-word-processing-document.md ✅Succeeded
docs/how-to-convert-a-word-processing-document-from-the-docm-to-the-docx-file-format.md ✅Succeeded
docs/how-to-copy-the-contents-of-an-open-xml-package-part-to-a-document-part-in-a-dif.md ✅Succeeded
docs/how-to-create-and-add-a-character-style-to-a-word-processing-document.md ✅Succeeded
docs/how-to-create-and-add-a-paragraph-style-to-a-word-processing-document.md ✅Succeeded
docs/how-to-create-a-package.md ✅Succeeded
docs/how-to-create-a-presentation-document-by-providing-a-file-name.md ✅Succeeded
docs/how-to-create-a-spreadsheet-document-by-providing-a-file-name.md ✅Succeeded
docs/how-to-create-a-word-processing-document-by-providing-a-file-name.md ✅Succeeded
docs/how-to-delete-all-the-comments-by-an-author-from-all-the-slides-in-a-presentatio.md ✅Succeeded
docs/how-to-delete-a-slide-from-a-presentation.md ✅Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@lindalu-MSFT lindalu-MSFT merged commit 889742b into OfficeDev:main Oct 17, 2023
1 check passed
Copy link
Collaborator

@lindalu-MSFT lindalu-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@twsouthwick twsouthwick deleted the tasou/remove-2.5 branch October 17, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to ECMA-376, Second Edition, Part 3 Incorrect
2 participants