Supporting the API Extractor/Documenter 7 Upgrade #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexJerabek
requested review from
kbrandl,
Rick-Kirkham,
Reezaali,
mscharlock and
ElizabethSamuel-MSFT
|
OPS Build status updates of commit 6789958: 🕙 Preparing: average preparing time is 1 min(s) 1 sec(s) |
1 similar comment
|
OPS Build status updates of commit 6789958: 🕙 Preparing: average preparing time is 1 min(s) 1 sec(s) |
|
OPS Build status updates of commit 6789958: 🕙 Incremental building: average incremental building time is 4 min(s) 59 sec(s) |
|
OPS Build status updates of commit 7ab27d4: 🕙 Preparing: average preparing time is 1 min(s) 1 sec(s) |
1 similar comment
|
OPS Build status updates of commit 7ab27d4: 🕙 Preparing: average preparing time is 1 min(s) 1 sec(s) |
|
OPS Build status updates of commit 7ab27d4: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
|
OPS Build status updates of commit 43f94e2: 🕙 Preparing: average preparing time is 1 min(s) 1 sec(s) |
1 similar comment
|
OPS Build status updates of commit 43f94e2: 🕙 Preparing: average preparing time is 1 min(s) 1 sec(s) |
|
OPS Build status updates of commit 43f94e2: 🕙 Incremental building: average incremental building time is 5 min(s) |
|
OPS Build status updates of commit 39e1325: 🕙 Preparing: average preparing time is 1 min(s) 1 sec(s) |
1 similar comment
|
OPS Build status updates of commit 39e1325: 🕙 Preparing: average preparing time is 1 min(s) 1 sec(s) |
|
OPS Build status updates of commit 39e1325: 🕙 Incremental building: average incremental building time is 5 min(s) 1 sec(s) |
|
OPS Build status updates of commit 39e1325: ✅ Validation status: passed
This comment lists only the first 50 files in the pull request. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
Rick-Kirkham
approved these changes
Jan 31, 2019
|
OPS Build status updates of commit 8c7dd40: 🕙 Preparing: average preparing time is 1 min(s) 2 sec(s) |
|
OPS Build status updates of commit 8c7dd40: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
|
OPS Build status updates of commit ae13592: 🕙 Preparing: average preparing time is 1 min(s) 1 sec(s) |
|
OPS Build status updates of commit ae13592: 🕙 Incremental building: average incremental building time is 5 min(s) |
|
OPS Build status updates of commit ae13592: ✅ Validation status: passed
This comment lists only the first 50 files in the pull request. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
|
OPS Build status updates of commit 88de77c: 🕙 Preparing: average preparing time is 1 min(s) 1 sec(s) |
|
OPS Build status updates of commit 88de77c: 🕙 Incremental building: average incremental building time is 5 min(s) |
|
OPS Build status updates of commit 88de77c: ✅ Validation status: passed
This comment lists only the first 50 files in the pull request. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
|
OPS Build status updates of commit c929371: 🕙 Preparing: average preparing time is 1 min(s) 1 sec(s) |
|
OPS Build status updates of commit c929371: 🕙 Incremental building: average incremental building time is 5 min(s) |
|
OPS Build status updates of commit c929371: ✅ Validation status: passed
This comment lists only the first 50 files in the pull request. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
ElizabethSamuel-MSFT
approved these changes
Feb 9, 2019
|
Thanks @ElizabethSamuel-MSFT. I'll check in after @Rick-Kirkham approves the latest changes (based on our internal thread). |
|
OPS Build status updates of commit 03b0449: 🕙 Preparing: average preparing time is 1 min(s) 1 sec(s) |
|
OPS Build status updates of commit 03b0449: 🕙 Incremental building: average incremental building time is 4 min(s) 59 sec(s) |
|
OPS Build status updates of commit 03b0449: ✅ Validation status: passed
This comment lists only the first 50 files in the pull request. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal review link
Here are the key changes:
Officeas well, so we map the imported namespace toCommonAPIand convert the text back later. As a side effect, the amount of warning text has greatly decreased.