-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: 1.1.0 with solidity 0.8 bump #33
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1.5.2
… code duplication
chore: bumps hardhat to v2.17.3
…s fully integrated in testnode
Bump executor to support CALL
Code hash of ArbMulticall2 is stored in constructor due to the contract size limits
Co-authored-by: gzeon <[email protected]>
Add multicall getters
Update local deployment scripts
Update depluyer script to provide multicall
yahgwai
approved these changes
Oct 25, 2023
godzillaba
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds transition of all smart contracts from old 0.6.x Solidity version to 0.8.17.
Includes:
Reason why custom version of ERC20Upgradeable is used instead of OpenZeppelin implementation directly is following - Openzeppelin removed
_decimals
storage variable in ERC20Upgradeable when they did their upgrade to 0.8 (commit here). They hard-coded decimals to 18 in getter, and if you want different number you have to store decimals yourself and override decimals() function. This is an issue because we're using ERC20Upgradeable as base for bridged standard ERC20 tokens (when token is 1st time bridged to L2 we automatically create token contract on L2). Beacon proxy is used which means there's a single implementation contract for all the bridged tokens out there (via standard bridge).Solution we used is -> copy paste Openzeppelin's ERC20Upgradeable locally, put back decimals variable and getter and setter, and use that contract as base for aeERC20/StandardArbERC20 instead of OZ import.
Also include a few other PR e.g.