Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node can act as Validator #361

Merged
merged 5 commits into from
Mar 14, 2022
Merged

node can act as Validator #361

merged 5 commits into from
Mar 14, 2022

Conversation

tsahee
Copy link
Collaborator

@tsahee tsahee commented Mar 14, 2022

No description provided.

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #361 (1d32715) into master (7c553ec) will decrease coverage by 7.60%.
The diff coverage is 32.81%.

@@            Coverage Diff             @@
##           master     #361      +/-   ##
==========================================
- Coverage   56.32%   48.71%   -7.61%     
==========================================
  Files         170      159      -11     
  Lines       20255    16016    -4239     
  Branches      455      455              
==========================================
- Hits        11408     7802    -3606     
+ Misses       7716     7073     -643     
- Partials     1131     1141      +10     

Copy link
Contributor

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Error! One parameter max!" in test-node.bash should be removed now

Copy link
Contributor

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit 1ba8a05 into master Mar 14, 2022
@PlasmaPower PlasmaPower deleted the validator branch March 14, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants