fix: 3074 support #168
Merged
fix: 3074 support #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlasmaPower
reviewed
Apr 15, 2024
| emit InboxMessageDeliveredFromOrigin(msgNum); | ||
| return msgNum; | ||
| function sendL2MessageFromOrigin(bytes calldata) external pure returns (uint256) { | ||
| revert Deprecated(); |
There was a problem hiding this comment.
Can't we just call the non-from-origin variant here? Afaik the only difference is gas usage, I don't think there's an aliasing difference or anything
There was a problem hiding this comment.
we can, but as described in the PR I don't think we need to and would prefer the simplicity of deprecating the function entirely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
sendL2MessageFromOriginSequencerInbox
fromOriginentrypoints are not removed yet, it will be fixed before EIP-3074 ship and when we have more clarity on its implementation. Since those entrypoints are only callable by the sequencer it pose less risk than the permissionlesssendL2MessageFromOriginand hence not removed in this PR for now.