Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge v1.14.7 #384

Merged
merged 16 commits into from
Feb 20, 2025
Merged

Merge v1.14.7 #384

merged 16 commits into from
Feb 20, 2025

Conversation

amsanghi
Copy link
Contributor

@amsanghi amsanghi commented Dec 9, 2024

fixes: NIT-2681

Merge upstream geth's v1.14.7 release into our geth fork:https://github.com/ethereum/go-ethereum/releases/tag/v1.14.7

nitro PR- OffchainLabs/nitro#2823

Testing done

geth and nitro tests pass

@cla-bot cla-bot
Copy link

cla-bot bot commented Dec 9, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@amsanghi amsanghi marked this pull request as ready for review December 9, 2024 14:47
@amsanghi amsanghi mentioned this pull request Dec 9, 2024
Merged
@cla-bot cla-bot
Copy link

cla-bot bot commented Dec 9, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@cla-bot cla-bot
Copy link

cla-bot bot commented Dec 12, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@cla-bot cla-bot
Copy link

cla-bot bot commented Dec 16, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

Base automatically changed from merge-v1.14.6 to master February 20, 2025 10:21
@cla-bot cla-bot
Copy link

cla-bot bot commented Feb 20, 2025

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@amsanghi amsanghi requested a review from eljobe February 20, 2025 10:37
eljobe
eljobe approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eljobe eljobe enabled auto-merge February 20, 2025 10:57
@eljobe eljobe merged commit 077cc89 into master Feb 20, 2025
7 of 8 checks passed
@eljobe eljobe deleted the merge-v1.14.7 branch February 20, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eljobe eljobe eljobe approved these changes

Assignees
No one assigned
Labels
design-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@amsanghi @eljobe @winniehere @gballet @fjl @sandakersmann @zhiqiangxu @holiman @arajasek @MariusVanDerWijden