Revamp and Add More to Stylus Cache Manager CLI #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gligneul
approved these changes
Aug 27, 2024
Comment on lines
+96
to
+103
| println!(""); | ||
| let note = format!( | ||
| r#"NOTE: We recommend running cargo stylus cache bid 0 {} to cache your activated contract in ArbOS. | ||
| Cached contracts benefit from cheaper calls. To read more about the Stylus contract cache, see | ||
| https://docs.arbitrum.io/stylus/concepts/stylus-cache-manager"#, | ||
| hex::encode(contract_addr), | ||
| ).debug_mint(); | ||
| println!("{note}"); |
There was a problem hiding this comment.
This notice format didn't work well. It is printing \n instead of actual new lines. Also, the address and bid arguments are inverted here.
"NOTE: We recommend running cargo stylus cache bid 0 611696c1cff8c63f4b3c5308300d355dc80c4b65 to cache your activated contract in ArbOS.\nCached contracts benefit from cheaper calls. To read more about the Stylus contract cache, see\nhttps://docs.arbitrum.io/stylus/concepts/stylus-cache-manager"
| } | ||
|
|
||
| fn format_gas(gas: u128) -> String { | ||
| let gas: u128 = gas.try_into().unwrap_or(u128::MAX); |
There was a problem hiding this comment.
The linter pointed out that this line could be removed, and it made sense. Maybe in the future we should block PRs from being merged if we get linter warnings.
Co-authored-by: Gabriel de Quadros Ligneul <[email protected]>
Fixed it up, thanks for the feedback!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses all recent feedback on cache manager commands for cargo stylus. It includes the following:
cargo stylus cache bid [ADDRESS] [AMOUNT]with documentationcargo stylus cache suggest-bid [ADDRESS], which gives the required bid for an address of a Stylus contractcargo stylus status --address=...which provides a status update on the cache, including information about whether or not a specified address is cached and other data from the cache managerThis PR also uses alloy in the entire
cachepackage instead of ethers-rs in an attempt to unify the cargo stylus repo to stick with alloy for Ethereum tooling