Support No reference Types in RUSTFLAGS by going from wasm->wat->wasm #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready again @rory-ocl and @joshuacolvin0 |
rauljordan
commented
Dec 11, 2024
gligneul
requested changes
Dec 11, 2024
…nLabs/cargo-stylus into support-removing-reference-types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR honors wasms that are built with
export RUSTFLAGS=-Ctarget-feature=-reference-typesby removing reference type mentions through a conversion from wasm->wat->wasm. This is accompanied by also locking down the Rust toolchain of cargo stylus to 1.83 and a PR to update stylus-hello-world to 1.83 with the specific Rust flag to disable reference types. This means that at the moment, with this change, there is no maximum Rust version limiting Stylus contracts or the SDK.Huge thanks to @PlasmaPower for the suggestion.