Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Convert repo to a monorepo #56

Closed
wants to merge 2 commits into from
Closed

Conversation

chrstph-dvx
Copy link
Contributor

@chrstph-dvx chrstph-dvx commented Dec 15, 2022

Summary

Split the logic into 2 different packages:

  • sdk containing most of the utilities function used by cli. The package meant to be used externally
  • cli the CLI generating the different token lists. The package meant for internal use, generating lists

Steps to test

All scripts should be working in cli should be working and produce the same token list as previously.

@DZGoldman
Copy link
Contributor

DZGoldman commented Dec 16, 2022

Thanks for putting this together!
Few things we should probably touch base on:

  • There's a few important changes currently on these branches that i want to make sure don't get lost.
  • My assumption would have been that the sdk package is the one that would be consumed externally, i.e., this would surface methods that other projects would use to generate / manage their own token lists, and the stuff more specific to OCL's needs would be siloed off elsewhere in a separate package (I haven't actually reviewed the code yet, so maybe it's already on track with what I had in mind)

@chrstph-dvx chrstph-dvx marked this pull request as draft December 29, 2022 11:02
@spsjvc spsjvc closed this Jun 6, 2023
@spsjvc spsjvc deleted the convert-to-monorepo branch June 6, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants