Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show comments on Channel fragment #54

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Show comments on Channel fragment #54

merged 1 commit into from
Nov 22, 2021

Conversation

kekkyojin
Copy link
Collaborator

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change

PR Type

What kind of change does this PR introduce?

  • Bugfix

Fixes

Issue Number: #1

What is the current behavior?

Comments on the Comments section for Channels aren't shown

What is the new behavior?

Now they are shown

@kekkyojin kekkyojin requested a review from akinwale November 16, 2021 19:33
akinwale
akinwale approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@akinwale akinwale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kekkyojin kekkyojin merged commit a2d92ad into master Nov 22, 2021
@kekkyojin kekkyojin deleted the comments-on-channel branch November 22, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akinwale akinwale akinwale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kekkyojin @akinwale