Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated app version to 2024.4 #374

Closed
wants to merge 2 commits into from
Closed

Conversation

benPearce1
Copy link
Collaborator

No description provided.

@benPearce1 benPearce1 requested a review from a team as a code owner January 16, 2025 08:03
Copy link

changeset-bot bot commented Jan 16, 2025

🦋 Changeset detected

Latest commit: 1a775e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
octopus-deploy Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@APErebus
Copy link
Contributor

You will need a changeset to trigger the versioning and release process

Copy link
Contributor

@liam-mackie liam-mackie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself is good, but needs a changeset as @APErebus mentioned.

Copy link
Contributor

@APErebus APErebus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liam-mackie If people install this new major version, will this upgrade their server version? I assume we use the app version for the tag, so it'll upgrade them?

Copy link
Contributor

@APErebus APErebus Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typically we use pnpm/npm... Not sure if we want to have yarn as well?

@@ -0,0 +1,5 @@
---
"octopus-deploy": major
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this. @liam-mackie ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a minor bump IMO, as there is nothing incompatible with the current version.

"octopus-deploy": major
---

Bumped octopus server version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can we make this more descriptive, something like Updated installed Octopus Server version to 2024.4`.

@liam-mackie
Copy link
Contributor

@liam-mackie If people install this new major version, will this upgrade their server version? I assume we use the app version for the tag, so it'll upgrade them?

Yes, if people install this new version, it will upgrade their server version. I don't think this is a bad thing, and we have previously updated the version this chart installs.

@benPearce1
Copy link
Collaborator Author

replaced by #375

@APErebus
Copy link
Contributor

Closing as it's been replaced by #375

@APErebus APErebus closed this Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants