Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide credentials for using during helm upgrade. #335

Merged
merged 12 commits into from
Nov 28, 2024
Merged

Conversation

rain-on
Copy link
Contributor

@rain-on rain-on commented Nov 25, 2024

Helm has a config file which contains credentials for the registries to which it is logged in (it can otherwise fallback on docker config).

This file is the same format as a docker config file.

{
     "auths": {
                     "<registry>": {
                              "auth":"dXNlcm5hbWU6cGFzc3dvcmQ="
                      }
       }
}

Where registry (for dockerhub) should be "https://index.docker.io/v1".
And "auth" is a basic auth string - i.e. a base64 encoding of <username>:<password>

While there are many more fields in this file, this is sufficient to get our e2e tests passing reliably.

@rain-on rain-on requested a review from a team as a code owner November 25, 2024 04:44
Copy link

changeset-bot bot commented Nov 25, 2024

🦋 Changeset detected

Latest commit: 1e8a479

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
kubernetes-agent

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@liam-mackie liam-mackie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments

@@ -322,7 +322,7 @@ persistence:
initial_backoff_seconds: ""
# -- The total time to retry failed NFS checks before giving up and deleting the pod
# @section -- Persistence
# @default 10
# @default 10:w!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# @default 10:w!
# @default 10

Looks like you accidentally stayed in insert mode 😅

Comment on lines 334 to 339
upgrade:
username: ""
password: ""
registry: ""


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
upgrade:
username: ""
password: ""
registry: ""
upgrade:
dockerAuth:
username: ""
password: ""
registry: ""

Consider changing the root from upgrade - it's not very descriptive.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I figured agent.upgrade.dockerAuth was actually quite nice.

Copy link
Contributor

@APErebus APErebus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 minor suggestion for the release notes, but LGTM!

.changeset/two-masks-relate.md Outdated Show resolved Hide resolved
@rain-on rain-on merged commit a3c9dec into main Nov 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants