fix: Check runbook variable context when prompt variable #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuyPhanNguyen
requested review from
hnrkndrssn,
benPearce1,
IsaacCalligeros95 and
grace-rehn
benPearce1
approved these changes
Feb 11, 2025
HuyPhanNguyen
deleted the
huy/2025/1/sc-103259-runbook-run-not-check-scope-variable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Variable Scope Checking in Runbook Run Command
Previously, when executing the
runbook runcommand, the CLI would prompt users for all variables marked as "Prompt", regardless of their scope. This meant users were being asked to provide values for variables that weren't actually relevant to their current context.For example, if a variable was scoped to Runbook2 or Process of ProjectA, but the user was running the runbook1, they would still be prompted for that variable's value.
Result
Fixes sc-103259
Fixes #479
Before
After