Changed the task output #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbristowe
reviewed
Dec 8, 2022
jbristowe
reviewed
Dec 8, 2022
jbristowe
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working through more usage examples it became apparent that the boolean output value wasn't quite enough to be able to reason about certain failure conditions.
The output has been changed to
task_stateso that error handling logic in the workflow makes more sense. The test workflow has been updated with a 2nd self test to illustrate how this can be utilised.Depends on OctopusDeploy/api-client.ts#127 for a fix to
ServerTaskWaiter, which wasn't cleaning up promises correctly in error cases