Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs server task id recomendation. #19

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

IsaacCalligeros95
Copy link
Contributor

@IsaacCalligeros95 IsaacCalligeros95 commented Apr 12, 2023

Currently the docs recommend fetching the server_task_id via {{steps.some_previous_deployment_step.outputs.server_tasks[0].server_task_id }}. This fails retrieving the task id
image

The original GitHub actions blog post recommends the approach below:
${{fromJson(steps.some_previous_deployment_step.outputs.server_tasks)[0].serverTaskId }} which works.

[sc-45926]

@IsaacCalligeros95 IsaacCalligeros95 requested a review from a team April 12, 2023 23:45
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #45926: Incorrect documentation on GitHub Actions await task step.

Copy link
Contributor

@hnrkndrssn hnrkndrssn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@IsaacCalligeros95 IsaacCalligeros95 merged commit 4493df5 into main Apr 12, 2023
@IsaacCalligeros95 IsaacCalligeros95 deleted the isaac/update-ServerTaskId-docs branch April 12, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants