(fix): Checking request has parameter before reading them #179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The list method of basicRepository allows us not passing any parameter/argument for our request.
But the Client, before performing the request, will check is the request is scape scoped by reading its parameters, using the isSpaceScopedRequest method of SpaceScopedRequest.
This method doesn't check that the parameters are not empty (= command is defined) before trying to access them; which result in a runtime error :
I encountered the issue while calling list without parameters on a SpaceRepository instance ; while trying to retrieve Spaces without any criterion.
The fix proposal is to check that the request do have parameters before accessing them; avoiding a runtime error when there isn't any parameter.