Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks like serverTaskWaiter.waitForTasks clears the "timeout" timeout immediately (in finally block). #178

Closed
jonagh opened this issue May 22, 2024 · 0 comments · Fixed by #180
Assignees

Comments

@jonagh
Copy link

jonagh commented May 22, 2024

I have added a comment to an issue in await-task-action, see: OctopusDeploy/await-task-action#22 (comment)

The await-task-action timeout value does not seem to do anything, and even the default value (600s) does not seem to work.
That action code uses the api-client's serverTaskWaiter to wait for tasks...

Looking at the serverTaskWaiter code it appears there is a bug where the timeout is cleared in a finally block immediately on the first wait loop iteration.

} finally {
clearTimeout(t);
}

Meaning the timeout period is effectively not used and the wait loop will go forever (or until the tasks complete).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants