Use .NET 8 SDK #68
Merged
Use .NET 8 SDK #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #65325: Upgrade minor libraries. |
YuKitsune
commented
Nov 23, 2023
| @@ -11,7 +9,6 @@ | |||
| using static Nuke.Common.Tools.DotNet.DotNetTasks; | |||
| using Nuke.Common.Tools.OctoVersion; | |||
|
|
|||
| [CheckBuildProjectConfigurations] | |||
There was a problem hiding this comment.
This has since been integrated into the SolutionAttribute.
https://github.com/nuke-build/nuke/blob/4a24cd4e78d43b59deb8aa2033c696c8ceb51dd6/source/Nuke.Common/Execution/CheckBuildProjectConfigurationsAttribute.cs#L18-L21
YuKitsune
commented
Nov 23, 2023
| @@ -26,20 +23,20 @@ class Build : NukeBuild | |||
| [Parameter("Branch name for OctoVersion to use to calculate the version number. Can be set via the environment variable " + CiBranchNameEnvVariable + ".", Name = CiBranchNameEnvVariable)] | |||
| readonly string OctoVersionBranch; | |||
|
|
|||
| [Parameter] readonly int? OctoVersionFullSemVer; | |||
| [Parameter] readonly string? OctoVersionFullSemVer; | |||
There was a problem hiding this comment.
This one caught me by surprise. After upgrading, Nuke started to complain about this. Weird that it wasn't doing it before.
YuKitsune
force-pushed
the
eoin/pet/net8
branch
from
0d1f29c to
8d52ebe
Compare
borland
reviewed
Nov 26, 2023
borland
approved these changes
Nov 26, 2023
Why? We'd need to upgrade it anyway to build the .NET 8 version of the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[sc-65325]
Updates this project to use the .NET 8 SDK for compilation and testing.
The library itself is still published under
netstandard2.0.